Skip to content

Optim-wip: Fix & Update WeightVisualization Notebook #820

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

ProGamerGov
Copy link
Contributor

@ProGamerGov ProGamerGov commented Dec 12, 2021

This notebook was originally created with an early version of the optim module, so it was nonfunctional and required updating.

GitHub's diff checker is reporting that the entire file changed, but I only changed a few lines of code.

  • Fixed the WeightVisualization notebook so that it works with the latest version of the optim module.

  • Updated the WeightVisualization notebook to use loss comprehension for faster rendering times.

* Fixed the WeightVisualization notebook so that it works with the latest version of the optim module.

* Updated the WeightVisualization notebook to use loss comprehension for faster rendering times.
@ProGamerGov
Copy link
Contributor Author

@NarineK This PR and #822 should be simple to review as they only contain a small number of fixes to existing tutorial notebooks.

@ProGamerGov
Copy link
Contributor Author

As Git wasn't able to properly show the changes, I'll list them below (about 90 lines were changed):

  • The show function and it's associated imports were removed as the function is part of the optim code library.
  • Transforms were missing the 's' in their calls, as previously they were accessed via transform.ExampleTransform, instead of transforms.ExampleTransform.
  • The visualization functions were updated to use batch targeting to render all the given targets at once.

@ProGamerGov
Copy link
Contributor Author

These images show the changes in this PR, as GitHub is not showing the correct file diff:
diff_1_wv
diff_2_wv
diff_3_wv
diff_4_wv
diff_5_wv

@ProGamerGov
Copy link
Contributor Author

@NarineK I added a set of images from an online diff checker as GitHub's diff checker isn't working on this PR.

@NarineK NarineK merged commit cbc6aac into pytorch:optim-wip May 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants