Skip to content

Optim-wip: Fix the Channel Attr notebook image download & metadata filename #822

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

ProGamerGov
Copy link
Contributor

@ProGamerGov ProGamerGov commented Dec 13, 2021

GitHub's diff checker is reporting that the entire file changed, but I only changed a few lines of code.

  • The image that this tutorial was using is no longer accessible as the hosting container for it was removed. I uploaded the image to GitHub and now the tutorial downloads it from GitHub instead.

  • Previously the filename in the metadata was listed as "CaptumNotebookCells.ipynb" instead of "ChannelAttribution_OptimViz.ipynb".

@NarineK
Copy link
Contributor

NarineK commented Jan 18, 2022

@ProGamerGov, do you mind pointing out here which lines did you change ?

@ProGamerGov
Copy link
Contributor Author

@NarineK I changed the rendering to use batch targeting so that we didn't have to render each item in the list separately. I also changed the image download link, and updated the transform path names: optimviz -> opt, transform -> transforms.

@NarineK
Copy link
Contributor

NarineK commented May 8, 2022

@ProGamerGov, do you mind looking into mypy checks and fixing them ?

@ProGamerGov
Copy link
Contributor Author

ProGamerGov commented May 8, 2022

@NarineK The MyPy error associated with the optim module is fixed in the optim-wip branch already

@NarineK
Copy link
Contributor

NarineK commented May 8, 2022

@ProGamerGov , do you mind then rebasing from the optim-wip branch so that the errors get fixed ?

@ProGamerGov
Copy link
Contributor Author

@NarineK Okay, I've done that and the error is no longer present, There will hopefully be no errors once the fixes from #935 are in play

@NarineK
Copy link
Contributor

NarineK commented May 9, 2022

Thank you, @ProGamerGov! I left comments in #935

@NarineK NarineK merged commit cf67101 into pytorch:optim-wip May 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants