-
Notifications
You must be signed in to change notification settings - Fork 516
Optim-wip: Miscellaneous Changes & Fixes #827
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optim-wip: Miscellaneous Changes & Fixes #827
Conversation
* `get_model_layers`, `collect_activations`, `Conv2dSame`, & `get_neuron_pos` were all missing documentation.
So, one thing that I'm not sure about is whether there should be an empty line between 'Args:' and the arguments:
vs
Captum seems to use both formats at the moment, though that could be fixed easily enough with regex. |
7a3239a
to
47d7a1b
Compare
* Fixed `image_cov` and the dataset tests. * Renamed `utils/image/dataset.py` to `utils/image/test_dataset.py` as the lack of a `test_` prefix was causing the tests not to be run. * Renamed `utils/image/common.py` to `utils/image/test_common.py` as the lack of a `test_` prefix was causing the tests not to be run. * Added missing `_dot_cossim` tests.
* Moved the `hue_to_rgb` function outside of `nchannels_to_rgb` for JIT support. * Fixed `nchannels_to_rgb` and `hue_to_rgb` functions. * Fixed `Direction` loss objective assert.
@NarineK The optim-wip branch does have a set version of black like the master branch, and thus a new update is causing the
|
This PR is mostly just the miscellaneous changes from the old atlas PRs.
ToRGB.klt_transform
andnchannels_to_rgb
.nchannels_to_rgb
function. Previously it wouldn't work on the GPU. Also added new and improved tests.vec
inDirection
,NeuronDirection
, &TensorDirection
. This should improve readability.In addition to the old PR changes, this PR also fixes the following:
Added documentation for
get_model_layers
,collect_activations
,Conv2dSame
, &get_neuron_pos
as they were all missing documentation.Fixed
image_cov
and the dataset tests.Renamed
utils/image/dataset.py
toutils/image/test_dataset.py
as the lack of atest_
prefix was causing the tests not to be run.Renamed
utils/image/common.py
toutils/image/test_common.py
as the lack of atest_
prefix was causing the tests not to be run.Added missing
_dot_cossim
tests.