Skip to content

Optim-wip: Fix & improve nchannels_to_rgb, hue_to_rgb #920

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

ProGamerGov
Copy link
Contributor

This contains the changes to nchannels_to_rgb & hue_to_rgb from: #827, to make it easier to review.

  • Fixed a bug in the function's calculations.
  • Added more tests for full testing coverage.
  • Separated out the the hue_to_rgb function from the nchannels_to_rgb, for JIT support and so that we can generate group colors separately.

@ProGamerGov ProGamerGov changed the title Fix & improve nchannels_to_rgb, hue_to_rgb Optim-wip: Fix & improve nchannels_to_rgb, hue_to_rgb Apr 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants