Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

document of parameter buffer_size in MaxTokenBucketizer is wrong #831

Closed
ling0322 opened this issue Oct 14, 2022 · 1 comment
Closed

document of parameter buffer_size in MaxTokenBucketizer is wrong #831

ling0322 opened this issue Oct 14, 2022 · 1 comment
Labels
documentation Improvements or additions to documentation

Comments

@ling0322
Copy link
Contributor

According to the document MaxTokenBucketizer
buffer_size – This restricts how many tokens are taken from prior DataPipe to bucketize

However, in the code, bucketbatcher.py#L277
The unit of buffer_size is sample not token
@ejguan ejguan added the documentation Improvements or additions to documentation label Oct 14, 2022
@ejguan
Copy link
Contributor

ejguan commented Oct 14, 2022

Thanks for reporting it. Feel free to open a PR to fix the inline doc.

@ling0322 ling0322 mentioned this issue Oct 17, 2022
Closed
ejguan pushed a commit to ejguan/data that referenced this issue Oct 21, 2022
@ling0322 @ejguan
Fix the document of buffer_size in max_token_bucketize (pytorch#834)
eaec62c 
Summary:
This PR would fix a document issue in bucketbatcher.py
Fixes pytorch#831

Pull Request resolved: pytorch#834

Reviewed By: NivekT

Differential Revision: D40430887

Pulled By: ejguan

fbshipit-source-id: e132a3a24e8d09815c36bba3ccd4ffaced7b17d4
ejguan pushed a commit that referenced this issue Oct 21, 2022
@ling0322 @ejguan
Fix the document of buffer_size in max_token_bucketize (#834)
a8fd731 
Summary:
This PR would fix a document issue in bucketbatcher.py
Fixes #831

Pull Request resolved: #834

Reviewed By: NivekT

Differential Revision: D40430887

Pulled By: ejguan

fbshipit-source-id: e132a3a24e8d09815c36bba3ccd4ffaced7b17d4
ejguan pushed a commit to ejguan/data that referenced this issue Oct 23, 2022
@ling0322 @ejguan
Fix the document of buffer_size in max_token_bucketize (pytorch#834)
6b56307 
Summary:
This PR would fix a document issue in bucketbatcher.py
Fixes pytorch#831

Pull Request resolved: pytorch#834

Reviewed By: NivekT

Differential Revision: D40430887

Pulled By: ejguan

fbshipit-source-id: e132a3a24e8d09815c36bba3ccd4ffaced7b17d4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix the document of buffer_size in max_token_bucketize
2 participants
@ling0322 @ejguan