Fix the document of buffer_size in max_token_bucketize #834
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to current implementation, the unit of buffer_size in MaxTokenBucketizerIterDataPipe is samples not tokens. Changed the document and replace tokens with samples
facebook-github-bot
added
the
CLA Signed
ejguan
approved these changes
Oct 17, 2022
|
@ejguan has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
NivekT
approved these changes
Oct 17, 2022
ejguan
pushed a commit
to ejguan/data
that referenced
this pull request
Oct 21, 2022
Summary: This PR would fix a document issue in bucketbatcher.py Fixes pytorch#831 Pull Request resolved: pytorch#834 Reviewed By: NivekT Differential Revision: D40430887 Pulled By: ejguan fbshipit-source-id: e132a3a24e8d09815c36bba3ccd4ffaced7b17d4
ejguan
pushed a commit
to ejguan/data
that referenced
this pull request
Oct 23, 2022
Summary: This PR would fix a document issue in bucketbatcher.py Fixes pytorch#831 Pull Request resolved: pytorch#834 Reviewed By: NivekT Differential Revision: D40430887 Pulled By: ejguan fbshipit-source-id: e132a3a24e8d09815c36bba3ccd4ffaced7b17d4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR would fix a document issue in bucketbatcher.py
Fixes #831