Improve graph visualization documentation #504
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
facebook-github-bot
added
the
CLA Signed
|
@NivekT has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
VitalyFedyunin
approved these changes
Jun 9, 2022
ejguan
approved these changes
Jun 9, 2022
Improve docstring, added an example, and expanded documentation to have a template for utility functions (not just class) If there isn't strong objection, I plan to cherry-pick this and the graph visualization PR to release 0.4.0 (cc: ejguan). [ghstack-poisoned]
|
@NivekT has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
Here you go:
|
|
Thank you! Looks great. |
NivekT
added a commit
that referenced
this pull request
Jun 9, 2022
Summary: Pull Request resolved: #504 Improve docstring, added an example, and expanded documentation to have a template for utility functions (not just class) If there isn't strong objection, I plan to cherry-pick this and the graph visualization PR to release 0.4.0 (cc: ejguan). Test Plan: Imported from OSS Reviewed By: ejguan Differential Revision: D37040783 Pulled By: NivekT fbshipit-source-id: 80b9569ad5a26b5a03e02d38001f88ec0599bc4b
NivekT
added a commit
that referenced
this pull request
Jun 9, 2022
Summary: Pull Request resolved: #504 Improve docstring, added an example, and expanded documentation to have a template for utility functions (not just class) If there isn't strong objection, I plan to cherry-pick this and the graph visualization PR to release 0.4.0 (cc: ejguan). Test Plan: Imported from OSS Reviewed By: ejguan Differential Revision: D37040783 Pulled By: NivekT fbshipit-source-id: 80b9569ad5a26b5a03e02d38001f88ec0599bc4b
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Improve docstring, added an example, and expanded documentation to have a template for utility functions (not just class)
If there isn't strong objection, I plan to cherry-pick this and the graph visualization PR to release 0.4.0 (cc: @ejguan).
Differential Revision: D37040783