Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update examples and tutorial after automatic sharding has landed #505

Closed
wants to merge 3 commits into from

Conversation

NivekT
Copy link
Contributor

@NivekT NivekT commented Jun 9, 2022

Stack from ghstack:

After the DataLoader automatic sharding for DataPipe PR has landed in core, this PR is updating the relevant example and tutorial

This should be cherry-picked to release.

Differential Revision: D37040383

NivekT added a commit that referenced this pull request Jun 9, 2022
ghstack-source-id: cf824aedd7de85c977b4bd0fe2eb840106c3a125
Pull Request resolved: #505
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 9, 2022
@NivekT
Copy link
Contributor Author

NivekT commented Jun 9, 2022

@NivekT has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

Copy link
Contributor

@ejguan ejguan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for keeping our document updated

README.md Outdated Show resolved Hide resolved
…landed"


After the `DataLoader` automatic sharding for DataPipe PR has landed in core, this PR is updating the relevant example and tutorial

This should be cherry-picked to release.

Differential Revision: [D37040383](https://our.internmc.facebook.com/intern/diff/D37040383)

[ghstack-poisoned]
NivekT added a commit that referenced this pull request Jun 9, 2022
ghstack-source-id: 37f8c80c20998c15438b7e4129cb518c49cdd1ac
Pull Request resolved: #505
README.md Outdated Show resolved Hide resolved
@NivekT
Copy link
Contributor Author

NivekT commented Jun 9, 2022

@NivekT has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

…landed"


After the `DataLoader` automatic sharding for DataPipe PR has landed in core, this PR is updating the relevant example and tutorial

This should be cherry-picked to release.

Differential Revision: [D37040383](https://our.internmc.facebook.com/intern/diff/D37040383)

[ghstack-poisoned]
NivekT added a commit that referenced this pull request Jun 9, 2022
ghstack-source-id: e0c9e57dc6bf6beaf91c1ba8e6e1249c89ea0bd0
Pull Request resolved: #505
@NivekT
Copy link
Contributor Author

NivekT commented Jun 9, 2022

@NivekT has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@NivekT NivekT mentioned this pull request Jun 9, 2022
NivekT added a commit that referenced this pull request Jun 9, 2022
Summary:
Pull Request resolved: #505

After the `DataLoader` automatic sharding for DataPipe PR has landed in core, this PR is updating the relevant example and tutorial

Test Plan: Imported from OSS

Reviewed By: VitalyFedyunin, ejguan

Differential Revision: D37040383

Pulled By: NivekT

fbshipit-source-id: 446b9e6a0ae804b1a0908a26058680f9b3c2f080
NivekT added a commit that referenced this pull request Jun 9, 2022
Summary:
Pull Request resolved: #505

After the `DataLoader` automatic sharding for DataPipe PR has landed in core, this PR is updating the relevant example and tutorial

Test Plan: Imported from OSS

Reviewed By: VitalyFedyunin, ejguan

Differential Revision: D37040383

Pulled By: NivekT

fbshipit-source-id: 446b9e6a0ae804b1a0908a26058680f9b3c2f080
NivekT added a commit that referenced this pull request Jun 9, 2022
…507)

* add utility to visualize datapipe graphs (#330)

Summary:
Closes #299.

Pull Request resolved: #330

Reviewed By: ejguan

Differential Revision: D36990978

Pulled By: NivekT

fbshipit-source-id: 423a52e6d59da59826d1422676d28287537dd902

* Update examples and tutorial after automatic sharding has landed (#505)

Summary:
Pull Request resolved: #505

After the `DataLoader` automatic sharding for DataPipe PR has landed in core, this PR is updating the relevant example and tutorial

Test Plan: Imported from OSS

Reviewed By: VitalyFedyunin, ejguan

Differential Revision: D37040383

Pulled By: NivekT

fbshipit-source-id: 446b9e6a0ae804b1a0908a26058680f9b3c2f080

Co-authored-by: Philip Meier <github.pmeier@posteo.de>
@facebook-github-bot facebook-github-bot deleted the gh/NivekT/82/head branch June 13, 2022 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants