[releng] Use PyTorch RC binary when testing on release branch #510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
@ejguan has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@ejguan has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@ejguan has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
ejguan
commented
Jun 10, 2022
| @@ -4,6 +4,7 @@ on: | |||
| branches: | |||
| - main | |||
| - release/* | |||
| tags: | |||
There was a problem hiding this comment.
Run CI when a release tag is added.
ejguan
commented
Jun 10, 2022
| @@ -9,7 +9,7 @@ on: | |||
| - main | |||
| # For PR created by ghstack | |||
| - gh/*/*/base | |||
| - release/* | |||
| # - release/* | |||
There was a problem hiding this comment.
Disable domain tests on release branch. This is not necessary because the cherry-picked PRs should have been verified not breaking domain tests and domains would also verify our RC releases (reduce the duplicate jobs).
ejguan
changed the title
|
This pull request has been reverted by 2e76749. |
ejguan
added a commit
to ejguan/data
that referenced
this pull request
Jun 10, 2022
Currently the CI on release branch uses nightly PyTorch release. This PR changes it to use RC PyTorch release. See the CI result of the PR for release branch: https://github.com/pytorch/data/runs/6835571789?check_suite_focus=true#step:8:3
ejguan
added a commit
that referenced
this pull request
Jun 13, 2022
Currently the CI on release branch uses nightly PyTorch release. This PR changes it to use RC PyTorch release. See the CI result of the PR for release branch: https://github.com/pytorch/data/runs/6835571789?check_suite_focus=true#step:8:3
ejguan
added a commit
to ejguan/data
that referenced
this pull request
Jun 13, 2022
Currently the CI on release branch uses nightly PyTorch release. This PR changes it to use RC PyTorch release. See the CI result of the PR for release branch: https://github.com/pytorch/data/runs/6835571789?check_suite_focus=true#step:8:3
ejguan
added a commit
to ejguan/data
that referenced
this pull request
Jun 13, 2022
Currently the CI on release branch uses nightly PyTorch release. This PR changes it to use RC PyTorch release. See the CI result of the PR for release branch: https://github.com/pytorch/data/runs/6835571789?check_suite_focus=true#step:8:3
facebook-github-bot
pushed a commit
that referenced
this pull request
Jun 13, 2022
Summary: Currently the CI on release branch uses nightly PyTorch release. This PR changes it to use RC PyTorch release. See the CI result for when the PR is landed (nightly channel): https://github.com/pytorch/data/runs/6867662390?check_suite_focus=true#step:8:3 See the CI result of the PR for release branch (test channel): https://github.com/pytorch/data/runs/6867788289?check_suite_focus=true#step:8:3 Pull Request resolved: #514 Reviewed By: NivekT Differential Revision: D37116635 Pulled By: ejguan fbshipit-source-id: 2dbe65da8121dfbd39690c83c2e1ca6cb70c0087
ejguan
added a commit
to ejguan/data
that referenced
this pull request
Jun 13, 2022
…ch#514) Summary: Currently the CI on release branch uses nightly PyTorch release. This PR changes it to use RC PyTorch release. See the CI result for when the PR is landed (nightly channel): https://github.com/pytorch/data/runs/6867662390?check_suite_focus=true#step:8:3 See the CI result of the PR for release branch (test channel): https://github.com/pytorch/data/runs/6867788289?check_suite_focus=true#step:8:3 Pull Request resolved: pytorch#514 Reviewed By: NivekT Differential Revision: D37116635 Pulled By: ejguan fbshipit-source-id: 2dbe65da8121dfbd39690c83c2e1ca6cb70c0087
ejguan
added a commit
that referenced
this pull request
Jun 13, 2022
Summary: Currently the CI on release branch uses nightly PyTorch release. This PR changes it to use RC PyTorch release. See the CI result for when the PR is landed (nightly channel): https://github.com/pytorch/data/runs/6867662390?check_suite_focus=true#step:8:3 See the CI result of the PR for release branch (test channel): https://github.com/pytorch/data/runs/6867788289?check_suite_focus=true#step:8:3 Pull Request resolved: #514 Reviewed By: NivekT Differential Revision: D37116635 Pulled By: ejguan fbshipit-source-id: 2dbe65da8121dfbd39690c83c2e1ca6cb70c0087
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the CI on release branch uses nightly PyTorch release. This PR changes it to use RC PyTorch release when the target branch of PR is the release branch or a commit is pushed to release branch.
See the CI result of the PR for release branch: https://github.com/pytorch/data/runs/6837219249?check_suite_focus=true#step:8:31