Re-land Use PyTorch RC release on release branch (#510) #514
Conversation
facebook-github-bot
added
the
CLA Signed
Currently the CI on release branch uses nightly PyTorch release. This PR changes it to use RC PyTorch release. See the CI result of the PR for release branch: https://github.com/pytorch/data/runs/6835571789?check_suite_focus=true#step:8:3
ejguan
force-pushed
the
ci_on_release_patch_2
branch
from
b50197b
to
6e93e2f
Compare
| - name: Get PyTorch Channel | ||
| shell: bash | ||
| run: | | ||
| if [[ "${{ github.base_ref }}" == release/* ]] || [[ "${{ github.ref }}" == refs/heads/release/* ]] || [[ "${{ github.ref }}" == refs/tags/v* ]]; then |
There was a problem hiding this comment.
Re-land due to undefined github.base_ref. Then, when it's not defined, the bash command will fail due to missing left operand for ==.
I need to wrap github.base_ref as an empty string to by-pass such scenario.
There was a problem hiding this comment.
noob question: Does the last condition mean that if the branch has a tag that starts with 'v', it will choose torch_test as the channel?
There was a problem hiding this comment.
Actually, the last condition refers to when a new tag that starts with v created. Not a branch.
There was a problem hiding this comment.
Have we been manually creating those tags?
There was a problem hiding this comment.
Yep. It's one step during release. I haven't created one for 0.4.0 yet because I will create the first rc at the end of today to incorporate the timeline of cherry-pick.
See all tags: https://github.com/pytorch/data/tags
|
@ejguan has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
| - name: Get PyTorch Channel | ||
| shell: bash | ||
| run: | | ||
| if [[ "${{ github.base_ref }}" == release/* ]] || [[ "${{ github.ref }}" == refs/heads/release/* ]] || [[ "${{ github.ref }}" == refs/tags/v* ]]; then |
There was a problem hiding this comment.
noob question: Does the last condition mean that if the branch has a tag that starts with 'v', it will choose torch_test as the channel?
…ch#514) Summary: Currently the CI on release branch uses nightly PyTorch release. This PR changes it to use RC PyTorch release. See the CI result for when the PR is landed (nightly channel): https://github.com/pytorch/data/runs/6867662390?check_suite_focus=true#step:8:3 See the CI result of the PR for release branch (test channel): https://github.com/pytorch/data/runs/6867788289?check_suite_focus=true#step:8:3 Pull Request resolved: pytorch#514 Reviewed By: NivekT Differential Revision: D37116635 Pulled By: ejguan fbshipit-source-id: 2dbe65da8121dfbd39690c83c2e1ca6cb70c0087
Summary: Currently the CI on release branch uses nightly PyTorch release. This PR changes it to use RC PyTorch release. See the CI result for when the PR is landed (nightly channel): https://github.com/pytorch/data/runs/6867662390?check_suite_focus=true#step:8:3 See the CI result of the PR for release branch (test channel): https://github.com/pytorch/data/runs/6867788289?check_suite_focus=true#step:8:3 Pull Request resolved: #514 Reviewed By: NivekT Differential Revision: D37116635 Pulled By: ejguan fbshipit-source-id: 2dbe65da8121dfbd39690c83c2e1ca6cb70c0087
Currently the CI tests on release branch use the nightly PyTorch release. This PR changes tests to use RC PyTorch release when the target branch of PR is the release branch or a commit is pushed to release branch.
Reverted PR: #510
See the CI result for when the PR is landed (nightly channel): https://github.com/pytorch/data/runs/6867662390?check_suite_focus=true#step:8:3
See the CI result of the PR for release branch (test channel): https://github.com/pytorch/data/runs/6867788289?check_suite_focus=true#step:8:3