[DataLoader2] Ensure finalize and finalize_iteration are called during shutdown/exception #846
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g shutdown/exception [ghstack-poisoned]
NivekT
added a commit
that referenced
this pull request
Oct 20, 2022
…g shutdown/exception ghstack-source-id: 526069dfff1a3171c44288f8f639639784515e9e Pull Request resolved: #846
facebook-github-bot
added
the
CLA Signed
NivekT
commented
Oct 20, 2022
| @@ -67,6 +67,11 @@ def __next__(self) -> T_co: | |||
| if self.dataloader.reading_service is not None: | |||
| self.dataloader.reading_service.finalize_iteration() | |||
| raise | |||
| except Exception: | |||
There was a problem hiding this comment.
- Is this potentially too broad? Should I limit this to specific exceptions? I wonder if users would want to intentionally catch exceptions that are raised here (such that finalization calls aren't needed).
- We can also call
DataLoader2.shutdown()here instead.
Thoughts?
There was a problem hiding this comment.
I think calling dl2.shutdown should be good
|
@NivekT has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
VitalyFedyunin
approved these changes
Oct 20, 2022
…alled during shutdown/exception" Fixes #821 1. Ensure `finalize_iteration` is called during `DataLoader2.shutdown()` 2. If an uncaught exception is raised by `DataLoader2Iterator.next()`, ensure finalization calls are made Differential Revision: [D40569566](https://our.internmc.facebook.com/intern/diff/D40569566) [ghstack-poisoned]
NivekT
added a commit
that referenced
this pull request
Oct 21, 2022
…g shutdown/exception ghstack-source-id: eb65f0a99f8dbc6c4b741b0d5d295ed082a08bdc Pull Request resolved: #846
|
@NivekT has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
ejguan
approved these changes
Oct 21, 2022
ejguan
pushed a commit
to ejguan/data
that referenced
this pull request
Oct 21, 2022
…eption (pytorch#846) Summary: Pull Request resolved: pytorch#846 Fixes pytorch#821 1. Ensure `finalize_iteration` is called during `DataLoader2.shutdown()` 2. If an uncaught exception is raised by `DataLoader2Iterator.next()`, ensure finalization calls are made Test Plan: Imported from OSS Reviewed By: ejguan Differential Revision: D40569566 Pulled By: NivekT fbshipit-source-id: f0768a62fcc6dfba1aef3a70c8c55563a45304aa
ejguan
pushed a commit
that referenced
this pull request
Oct 21, 2022
…eption (#846) Summary: Pull Request resolved: #846 Fixes #821 1. Ensure `finalize_iteration` is called during `DataLoader2.shutdown()` 2. If an uncaught exception is raised by `DataLoader2Iterator.next()`, ensure finalization calls are made Test Plan: Imported from OSS Reviewed By: ejguan Differential Revision: D40569566 Pulled By: NivekT fbshipit-source-id: f0768a62fcc6dfba1aef3a70c8c55563a45304aa
ejguan
pushed a commit
to ejguan/data
that referenced
this pull request
Oct 23, 2022
…eption (pytorch#846) Summary: Pull Request resolved: pytorch#846 Fixes pytorch#821 1. Ensure `finalize_iteration` is called during `DataLoader2.shutdown()` 2. If an uncaught exception is raised by `DataLoader2Iterator.next()`, ensure finalization calls are made Test Plan: Imported from OSS Reviewed By: ejguan Differential Revision: D40569566 Pulled By: NivekT fbshipit-source-id: f0768a62fcc6dfba1aef3a70c8c55563a45304aa
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Fixes #821
finalize_iterationis called duringDataLoader2.shutdown()DataLoader2Iterator.next(), ensure finalization calls are madeDifferential Revision: D40569566