Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DataLoader2] Ensure finalize and finalize_iteration are called during shutdown/exception #846

Closed
wants to merge 2 commits into from
Closed

[DataLoader2] Ensure finalize and finalize_iteration are called during shutdown/exception #846

wants to merge 2 commits into from

Commits on Oct 20, 2022

  1. [DataLoader2] Ensure finalize and finalize_iteration are called durin… 

    …g shutdown/exception

[ghstack-poisoned]
    @NivekT
    NivekT committed Oct 20, 2022
    Configuration menu
    Copy the full SHA
    65b923a View commit details
    Browse the repository at this point in the history

Commits on Oct 21, 2022

  1. Update on "[DataLoader2] Ensure finalize and finalize_iteration are c… 

    …alled during shutdown/exception"


Fixes #821

1. Ensure `finalize_iteration` is called during `DataLoader2.shutdown()`
2. If an uncaught exception is raised by `DataLoader2Iterator.next()`, ensure finalization calls are made

Differential Revision: [D40569566](https://our.internmc.facebook.com/intern/diff/D40569566)

[ghstack-poisoned]
    @NivekT
    NivekT committed Oct 21, 2022
    Configuration menu
    Copy the full SHA
    b675fb4 View commit details
    Browse the repository at this point in the history