Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecating DataPipes #909

Closed
wants to merge 1 commit into from
Closed

Conversation

ejguan
Copy link
Contributor

@ejguan ejguan commented Nov 28, 2022

Summary: per title

Differential Revision: D41563765

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported labels Nov 28, 2022
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D41563765

ejguan added a commit to ejguan/data that referenced this pull request Nov 28, 2022
Summary:
X-link: pytorch/pytorch#89794

Pull Request resolved: pytorch#909

per title

Differential Revision: D41563765

fbshipit-source-id: b0b283ceb63a60aaa25b12a2b0d1b536ff5ccf85
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D41563765

Copy link
Contributor

@NivekT NivekT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

Summary:
X-link: pytorch/pytorch#89794

Pull Request resolved: pytorch#909

per title

Reviewed By: wenleix, NivekT

Differential Revision: D41563765

fbshipit-source-id: 91c01e433bf0b48a53b42628acc3e056920df283
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D41563765

ejguan added a commit to ejguan/pytorch that referenced this pull request Nov 29, 2022
Summary:
Pull Request resolved: pytorch#89794

X-link: pytorch/data#909

per title

Test Plan:
`buck2 test buck2 test //caffe2/test:datapipe` https://www.internalfb.com/intern/testinfra/testrun/4222124790012281

`buck2 test //pytorch/data/test:tests`

Reviewed By: wenleix, NivekT

Differential Revision: D41563765

fbshipit-source-id: aa934bf87645f31a5ab1cf04beddcc9b910aea82
@ejguan ejguan added the topic: deprecation topic category label Dec 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported topic: deprecation topic category
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants