Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Nova] Remove Linux and Mac Unittests from CircleCI #1993

Merged
merged 1 commit into from
Nov 30, 2022
Merged

[Nova] Remove Linux and Mac Unittests from CircleCI #1993

merged 1 commit into from
Nov 30, 2022

Conversation

osalpekar
Copy link
Member

@osalpekar osalpekar commented Nov 28, 2022 •
edited
Loading

Linux and Mac Unittests are running via Nova/GHA for some time now. Deprecating the CircleCI ones.

@osalpekar osalpekar marked this pull request as ready for review November 29, 2022 23:52
@osalpekar osalpekar mentioned this pull request Nov 29, 2022
Closed
@joecummings
Copy link
Contributor

joecummings commented Nov 30, 2022 •
edited
Loading

Looks like there is a new test consistently failing - can you look into this before I approve @osalpekar ?

@osalpekar
Copy link
Member Author

Looks like there is a new test consistently failing - can you look into this before I approve @osalpekar ?

@joecummings I just spoke with @ejguan, and looks like this might be related to some deprecated ops being removed from torchdata in pytorch/data#909. Erjia's looking into creating a patch to torchtext that will fix these failures.

@joecummings
Copy link
Contributor

@osalpekar Now that the patch has landed, can you rebase here to confirm the fix?

@joecummings
Copy link
Contributor

Linux failure is fine (related to known ISWLT dataset issue), but there's another failure for the M1 wheels @osalpekar .

@osalpekar
Copy link
Member Author

@joecummings I re-ran the M1 job and it's green now. Looks like some flakiness in the M1 GitHub machines that we've been seeing since this morning.

joecummings
joecummings approved these changes Nov 30, 2022
View reviewed changes
Copy link
Contributor

@joecummings joecummings left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@osalpekar osalpekar merged commit b1d9447 into pytorch:main Nov 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joecummings joecummings joecummings approved these changes

@Nayef211 Nayef211 Awaiting requested review from Nayef211

@weiwangmeta weiwangmeta Awaiting requested review from weiwangmeta

@abhinavarora abhinavarora Awaiting requested review from abhinavarora

Assignees
No one assigned
Labels
cla signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@osalpekar @joecummings @facebook-github-bot