Skip to content

Temporarily disable windows preset build in CI #13669

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 25, 2025
Merged

Temporarily disable windows preset build in CI #13669

merged 2 commits into from
Aug 25, 2025

Conversation

GregoryComer
Copy link
Member

@GregoryComer GregoryComer commented Aug 25, 2025 •
edited
Loading

Job is failing on trunk. Temporarily disabling while I resolve it.

@GregoryComer
Update
e3b4174 
[ghstack-poisoned]
@GregoryComer
Copy link
Member Author

GregoryComer commented Aug 25, 2025 •
edited
Loading

Stack from ghstack (oldest at bottom):

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Aug 25, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/13669

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 43 Pending

As of commit a3ebd0e with merge base 1d832ad (image):

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

GregoryComer added a commit that referenced this pull request Aug 25, 2025
@GregoryComer
Temporarily disable windows preset build in CI
4898818 
ghstack-source-id: 4d0865f
ghstack-comment-id: 3222031439
Pull-Request: #13669
@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 25, 2025
@github-actions GitHub Actions
Copy link

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@GregoryComer
Update
a3ebd0e 
[ghstack-poisoned]
GregoryComer added a commit that referenced this pull request Aug 25, 2025
@GregoryComer
Temporarily disable windows preset build in CI
b27bd95 
ghstack-source-id: 1448843
ghstack-comment-id: 3222031439
Pull-Request: #13669
@GregoryComer GregoryComer merged commit 484ed13 into main Aug 25, 2025
106 of 109 checks passed
@GregoryComer GregoryComer deleted the gh/GregoryComer/139/head branch August 25, 2025 23:47
agrima1304 pushed a commit to agrima1304/executorch that referenced this pull request Aug 26, 2025
@GregoryComer @agrima1304
Temporarily disable windows preset build in CI (pytorch#13669)
b78e768 
Job is failing on trunk. Temporarily disabling while I resolve it.
@GregoryComer GregoryComer mentioned this pull request Aug 26, 2025
Merged
GregoryComer added a commit that referenced this pull request Aug 26, 2025
@GregoryComer
Re-enable Windows build CI (#13699)
034ff5d 
The Windows CI build job was disabled in
#13669 due to a new Windows
build failure in #13485. Since
that diff was reverted in
#13685, we can re-enable the
job.

I started fixing the issue in
#13672, but dropped it due to
the revert. It's a simple change, so it can likely be bundled when the
affected PR is re-landed.

Test Plan:
The Build Preset / Windows job is passing on this PR.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JacobSzwejbka JacobSzwejbka JacobSzwejbka approved these changes

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@GregoryComer @JacobSzwejbka