Skip to content

Revert "Add check_for_installed_private_headers_in_cmake_out" #13685

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 26, 2025
Merged

Revert "Add check_for_installed_private_headers_in_cmake_out" #13685

merged 1 commit into from
Aug 26, 2025

Conversation

jackzhxng
Copy link
Contributor

Reverts #13485

@pytorch-bot pytorch-bot bot added the ci-no-td label Aug 26, 2025
@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Aug 26, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/13685

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 New Failures

As of commit 2b3bd6c with merge base dd16790 (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 26, 2025
@jackzhxng jackzhxng added the release notes: none Do not include this in the release notes label Aug 26, 2025
@jackzhxng jackzhxng merged commit f15982d into main Aug 26, 2025
443 of 455 checks passed
@jackzhxng jackzhxng deleted the revert-13485-gh/swolchok/551/head branch August 26, 2025 19:52
@GregoryComer GregoryComer mentioned this pull request Aug 26, 2025
Merged
GregoryComer added a commit that referenced this pull request Aug 26, 2025
@GregoryComer
Re-enable Windows build CI (#13699)
034ff5d 
The Windows CI build job was disabled in
#13669 due to a new Windows
build failure in #13485. Since
that diff was reverted in
#13685, we can re-enable the
job.

I started fixing the issue in
#13672, but dropped it due to
the revert. It's a simple change, so it can likely be bundled when the
affected PR is re-landed.

Test Plan:
The Build Preset / Windows job is passing on this PR.
@swolchok swolchok mentioned this pull request Sep 2, 2025
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JacobSzwejbka JacobSzwejbka JacobSzwejbka approved these changes

@larryliu0820 larryliu0820 Awaiting requested review from larryliu0820 larryliu0820 is a code owner

@kirklandsign kirklandsign Awaiting requested review from kirklandsign kirklandsign is a code owner

Assignees
No one assigned
Labels
ci-no-td CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. release notes: none Do not include this in the release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jackzhxng @JacobSzwejbka