Skip to content

Support sine operator on XNNPACK #14711

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 13, 2025
Merged

Support sine operator on XNNPACK #14711

merged 1 commit into from
Oct 13, 2025
+160 −0

Conversation

GregoryComer
Copy link
Member

Summary: Wire up the unary sine operator in xnnpack for fp32 and fp16.

Differential Revision: D83623086

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Oct 1, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/14711

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 New Failures, 1 Cancelled Job

As of commit 68f6f0e with merge base 53ccfd0 (image):

NEW FAILURES - The following jobs have failed:

CANCELLED JOB - The following job was cancelled. Please retry:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 1, 2025
@facebook-github-bot
Copy link
Contributor

@GregoryComer has exported this pull request. If you are a Meta employee, you can view the originating Diff in D83623086.

@GregoryComer GregoryComer added the release notes: xnnpack Changes to the XNNPack backend delegate label Oct 1, 2025
@GregoryComer
Copy link
Member Author

Cosine is coming in D83623619, will export as a PR once this is merged because I didn't use ghexport.

@facebook-github-bot
Copy link
Contributor

@GregoryComer has imported this pull request. If you are a Meta employee, you can view this in D83623086.

@GregoryComer @facebook-github-bot
Support sine operator on XNNPACK (pytorch#14711)
68f6f0e 
Summary:
Wire up the unary sine operator in xnnpack for fp32 and fp16.


Differential Revision: D83623086

Pulled By: GregoryComer
@GregoryComer GregoryComer merged commit 6efddba into pytorch:main Oct 13, 2025
128 of 133 checks passed
@digantdesai
Copy link
Contributor

cherry pick on to 1.0?

@GregoryComer
Copy link
Member Author

cherry pick on to 1.0?

I wasn't originally planning to, given that it's late, but it's reasonably low risk so I'm okay to pick it if you'd like.

@GregoryComer
Copy link
Member Author

@pytorchbot cherry-pick --onto release/1.0 -c critical

pytorchbot pushed a commit that referenced this pull request Oct 15, 2025
@GregoryComer @pytorchbot
Support sine operator on XNNPACK (#14711)
2e2916b 
Summary: Wire up the unary sine operator in xnnpack for fp32 and fp16.

Differential Revision: D83623086

(cherry picked from commit 6efddba)
@pytorchbot
Copy link
Collaborator

Cherry picking #14711

The cherry pick PR is at #15144 and it is recommended to link a critical cherry pick PR with an issue. The following tracker issues are updated:

Details for Dev Infra team Raised by workflow job

@pytorchbot pytorchbot mentioned this pull request Oct 15, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@digantdesai digantdesai digantdesai approved these changes

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported meta-exported release notes: xnnpack Changes to the XNNPack backend delegate

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@GregoryComer @facebook-github-bot @digantdesai @pytorchbot