Skip to content

Conversation

pytorchbot
Copy link
Collaborator

Summary: Wire up the unary sine operator in xnnpack for fp32 and fp16.

Differential Revision: D83623086

Summary: Wire up the unary sine operator in xnnpack for fp32 and fp16.

Differential Revision: D83623086

(cherry picked from commit 6efddba)
Copy link

pytorch-bot bot commented Oct 15, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/15144

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 2 Cancelled Jobs, 1 Unrelated Failure

As of commit 2e2916b with merge base e0dda90 (image):

NEW FAILURE - The following job has failed:

CANCELLED JOBS - The following jobs were cancelled. Please retry:

FLAKY - The following job failed but was likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 15, 2025
@GregoryComer
Copy link
Member

GregoryComer commented Oct 15, 2025

@digantdesai This is causing a very slight difference in output in the llava runner ("photo" -> "photograph"), causing the test to fail. This appears benign. Since you requested the pick, I'll defer to you. Is this a concern? Should I land it and forward fix the test on the branch? Or drop the pick? Given that it's conceptually low risk, I'm okay to merge it this afternoon, but any later and I will need to drop it.

Edit: It looks like the test was disabled on main in #14285 but not picked.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants