Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Dispatch for SAC loss module #1223

Merged
merged 3 commits into from
Jun 4, 2023
Merged

[Feature] Dispatch for SAC loss module #1223

merged 3 commits into from
Jun 4, 2023

Conversation

Blonck
Copy link
Contributor

@Blonck Blonck commented Jun 2, 2023

Description

Enable dispatching arguments for the .forward() method of the SAC loss module.

Types of changes

What types of changes does your code introduce? Remove all that do not apply:

  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (update in the documentation)

Checklist

Go over all the following points, and put an x in all the boxes that apply.
If you are unsure about any of these, don't hesitate to ask. We are here to help!

  • I have read the CONTRIBUTION guide (required)
  • I have updated the tests accordingly (required for a bug fix or a new feature).
  • I have updated the documentation accordingly.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 2, 2023
@Blonck
Copy link
Contributor Author

Blonck commented Jun 2, 2023

This PR is not ready. The "done" and "reward" key does not handle nested keys properly. Should be fixed in another patch.

@Blonck
Copy link
Contributor Author

Blonck commented Jun 3, 2023

Now it is ready. pytorch/tensordict@d2edd94 solved the problem.

@Blonck Blonck requested a review from vmoens June 3, 2023 08:36
@Blonck Blonck changed the title Dispatch for SAC loss module [Feature] Dispatch for SAC loss module Jun 4, 2023
@Blonck Blonck added the enhancement New feature or request label Jun 4, 2023
vmoens
vmoens approved these changes Jun 4, 2023
View reviewed changes
Copy link
Contributor

@vmoens vmoens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool stuff thanks a mil!

@vmoens vmoens merged commit 3aab983 into pytorch:main Jun 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vmoens vmoens vmoens approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Blonck @vmoens @facebook-github-bot