Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Nested keys in OrnsteinUhlenbeckProcess #1305

Merged
merged 22 commits into from
Jul 6, 2023
Merged

[Feature] Nested keys in OrnsteinUhlenbeckProcess #1305

merged 22 commits into from
Jul 6, 2023

Conversation

matteobettini
Copy link
Contributor

@matteobettini matteobettini commented Jun 21, 2023 •
edited
Loading

No description provided.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 21, 2023
matteobettini and others added 7 commits June 21, 2023 17:09
@matteobettini
fix
37b27bb
@matteobettini
fix
04ace53
@matteobettini
refactor
02e8b0c
@matteobettini
amend
7bee22a
@matteobettini
amend
14e32b8
@matteobettini
Merge branch 'main' into exploration
eee79e7 
# Conflicts:
#	test/mocking_classes.py
#	test/test_env.py
@matteobettini
amend
14be604 
Signed-off-by: Matteo Bettini <matbet@meta.com>
@matteobettini matteobettini marked this pull request as draft July 6, 2023 13:25
@matteobettini
amend
6c28005 
Signed-off-by: Matteo Bettini <matbet@meta.com>
@matteobettini
amend
fd1757c 
Signed-off-by: Matteo Bettini <matbet@meta.com>
@matteobettini
amend
15e6036 
Signed-off-by: Matteo Bettini <matbet@meta.com>
@matteobettini
clean
4b21cf6 
Signed-off-by: Matteo Bettini <matbet@meta.com>
@matteobettini
amend
540c03c 
Signed-off-by: Matteo Bettini <matbet@meta.com>
@matteobettini
solve issue
b6ca5b1 
Signed-off-by: Matteo Bettini <matbet@meta.com>
@matteobettini
solve issue
a77b4b1 
Signed-off-by: Matteo Bettini <matbet@meta.com>
vmoens
vmoens approved these changes Jul 6, 2023
View reviewed changes
Copy link
Contributor

@vmoens vmoens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks for this!

torchrl/collectors/collectors.py Outdated Show resolved Hide resolved
torchrl/modules/tensordict_module/exploration.py Show resolved Hide resolved
torchrl/modules/tensordict_module/exploration.py Show resolved Hide resolved
@matteobettini
docstring
90d52cd 
Signed-off-by: Matteo Bettini <matbet@meta.com>
@matteobettini matteobettini marked this pull request as ready for review July 6, 2023 15:40
@vmoens vmoens merged commit 2a477a2 into pytorch:main Jul 6, 2023
@matteobettini matteobettini deleted the exploration branch July 6, 2023 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vmoens vmoens vmoens approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@matteobettini @vmoens @facebook-github-bot