[Feature, NOMERGE] RLHF Rollouts (reopened) #1329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
vmoens
changed the title
|
@tcbegley I think we should merge/rebase main into this |
tcbegley
force-pushed
the
rlhf-rollout
branch
2 times, most recently
from
897649b
to
ebed304
Compare
|
I've rebased and fixed up the tests. There's still the changes from #1328 visible in the history here because I need the reward model for the rollout. Once that's merged (I think it's ready), I'll do a final merge / rebase and we should be ready here too. |
vmoens
commented
Jun 28, 2023
| EOS_TOKEN_ID = 50256 | ||
|
|
||
| def __init__( | ||
| self, model, ref_model, reward_model, max_new_tokens=50, score_clip=10.0 |
There was a problem hiding this comment.
long term we may want to make this reward model optional and leave to the user the option of computing reward at a different time (eg when populating the replay buffer)
Co-authored-by: Alessandro Pietro Bardelli <apbard@users.noreply.github.com>
Co-authored-by: Vincent Moens <vincentmoens@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #1315 for discussion