Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleaning up previous runs from GPU runner #2676

Merged
merged 4 commits into from
Oct 4, 2023
Merged

Conversation

agunapal
Copy link
Collaborator

@agunapal agunapal commented Oct 4, 2023

Description

This PR cleans up the workspace directory fully from the CI GPU runners.

Fixes #(issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

Feature/Issue validation/testing

Please describe the Unit or Integration tests that you ran to verify your changes and relevant result summary. Provide instructions so it can be reproduced.
Please also list any relevant details for your test configuration.

  • Test A
    Logs for Test A

  • Test B
    Logs for Test B

Checklist:

  • Did you have fun?
  • Have you added tests that prove your fix is effective or that this feature works?
  • Has code been commented, particularly in hard-to-understand areas?
  • Have you made corresponding changes to the documentation?

@agunapal agunapal changed the title (WIP)Cleaning up previous runner Cleaning up previous runs from GPU runner Oct 4, 2023
@agunapal agunapal requested a review from msaroufim October 4, 2023 16:51
@msaroufim
Copy link
Member

Let's wait on ci, might also need to skip the streaming handler tests to actually merge this

I would have expected cd $RUNNER_WORKSPACE to stick around

@codecov
Copy link

codecov bot commented Oct 4, 2023

Codecov Report

Merging #2676 (ee73c39) into master (88a19de) will not change coverage.
The diff coverage is n/a.

❗ Current head ee73c39 differs from pull request most recent head 5eca608. Consider uploading reports for the commit 5eca608 to get more accurate results

@@           Coverage Diff           @@
##           master    #2676   +/-   ##
=======================================
  Coverage   72.39%   72.39%           
=======================================
  Files          85       85           
  Lines        3956     3956           
  Branches       58       58           
=======================================
  Hits         2864     2864           
  Misses       1088     1088           
  Partials        4        4           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@agunapal agunapal requested review from lxning and mreso October 4, 2023 17:07
Comment on lines 23 to 26
ls -la ./
sudo rm -rf ./* || true
sudo rm -rf ./.??* || true
ls -la ./
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we need specify the path and then delete

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

@msaroufim msaroufim Oct 4, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you maybe add a comment to more explicitly say what this is trying to achieve? As in which files are folders are you targeting for cleanup

The benefit of not having * in remove commands is we can be more explicit about what's being deleted

@agunapal agunapal requested a review from lxning October 4, 2023 18:07
@msaroufim
Copy link
Member

Just so we can move on

# deletes all files in the current directory
sudo rm -rf ./* || true
# deletes all hidden files in a directory
sudo rm -rf ./.??* || true
``

@msaroufim msaroufim enabled auto-merge October 4, 2023 18:10
@msaroufim msaroufim added this pull request to the merge queue Oct 4, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 4, 2023
@agunapal agunapal added this pull request to the merge queue Oct 4, 2023
Merged via the queue into master with commit 40ce269 Oct 4, 2023
@agunapal agunapal deleted the issues/clean_up_runner branch October 4, 2023 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants