-
Notifications
You must be signed in to change notification settings - Fork 875
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleaning up previous runs from GPU runner #2676
Conversation
Let's wait on ci, might also need to skip the streaming handler tests to actually merge this I would have expected |
Codecov Report
@@ Coverage Diff @@
## master #2676 +/- ##
=======================================
Coverage 72.39% 72.39%
=======================================
Files 85 85
Lines 3956 3956
Branches 58 58
=======================================
Hits 2864 2864
Misses 1088 1088
Partials 4 4 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
.github/workflows/ci_gpu.yml
Outdated
ls -la ./ | ||
sudo rm -rf ./* || true | ||
sudo rm -rf ./.??* || true | ||
ls -la ./ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we need specify the path and then delete
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesn't work https://github.com/pytorch/serve/actions/runs/6409297939
Also, we have been doing the same in Regression GPU runners and it works
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you maybe add a comment to more explicitly say what this is trying to achieve? As in which files are folders are you targeting for cleanup
The benefit of not having *
in remove commands is we can be more explicit about what's being deleted
Just so we can move on # deletes all files in the current directory
sudo rm -rf ./* || true
# deletes all hidden files in a directory
sudo rm -rf ./.??* || true
`` |
Description
This PR cleans up the workspace directory fully from the CI GPU runners.
Fixes #(issue)
Type of change
Please delete options that are not relevant.
Feature/Issue validation/testing
Please describe the Unit or Integration tests that you ran to verify your changes and relevant result summary. Provide instructions so it can be reproduced.
Please also list any relevant details for your test configuration.
Test A
Logs for Test A
Test B
Logs for Test B
Checklist: