Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store artifacts of rendered docs so that rendered docs can be checked on each PR #1288

Merged
merged 1 commit into from
Apr 21, 2021

Conversation

NicolasHug
Copy link
Member

The build_docs CI run builds the doc on every PR but the artifacts aren't saved, so we can't access the rendered html files.

This PR saves the artifacts so that the built docs can be browsed on each PR by going in the "Artifacts" tab of the build_docs CI run.

@NicolasHug
Copy link
Member Author

Copy link
Contributor

@vincentqb vincentqb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, same as torchaudio and pytorch/audio#1321

@NicolasHug NicolasHug merged commit d90219d into pytorch:master Apr 21, 2021
@NicolasHug NicolasHug deleted the artifacts branch April 21, 2021 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants