Update v0.7.0 release branch with master #886
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Eli Uriegas <eliuriegas@fb.com>
bump nightlies to 0.8.0
* Adding new factory methods for vectors * Added factory methods * Updated test assets and implementations * Debugging tests * Finished tests for glove and fasttext * Resolving PR comments * Added checksum validation for fasttext and glove * Fixed all tests * Updated tests * Benchmarking various vectors implementation * Added script to compute fast text checksums * Removed Json files * updated to stovec without hash * Testing optimizations * Benchmarking various experiments * Benchmarking * Debugging dim error * Updated loading vector from file * Fixed dup token bug * Removing unwanted changes * Removing unwanted changes * Delimiting by user specified char * Fixed dupe check * Fixing dupe line bug
* Adding dunder methods to cpp Vectors * Fix length * Fixed pytest errors * Fixed stylecheck
* Updating serialization methods * Profiling serialization * Added 2d tensor support with dict * Updating becnhmark and vectors * Updated vectors for stovec implementation * Cleaning up PR * Cleaning up PR * Updated tests and fixed lint * Added new function for vectors from tokens * Linting * linting * Using dict.insert_or_assign * Removed get vectors by tokens * Fixing style checks
* Adding new vocab class * Wrote the cpp Vocab class * Completed vocab class * Fixing style check * resolving PR comments * Using c::10 dict * Added tests for new functions * Fixing bug with specials tuple * Annotated function return types * Using camel case for function names * Resolving PR comments * Fixing unit tests * Updated method names * Updated vocab with unk_token in specials and updated tests * Updated docstring to show example for Vocab class
* Adding new vocab class * Wrote the cpp Vocab class * Completed vocab class * Fixing style check * resolving PR comments * Using c::10 dict * Added tests for new functions * Added benchmarking code for vovab * Fixing bug with specials tuple * Added benchmarking code for vocab class * Annotated function return types * Using camel case for function names * Resolving PR comments * Fixing unit tests * Updated method names * Updated vocab with unk_token in specials and updated tests * Updated docstring to show example for Vocab class
* minor doc update * checkpoint Co-authored-by: Guanheng Zhang <zhangguanheng@devfair0197.h2.fair>
* Updating serialization methods * Profiling serialization * Added 2d tensor support with dict * Updating becnhmark and vectors * Updated vectors for stovec implementation * Cleaning up PR * Cleaning up PR * Updated tests and fixed lint * Added new function for vectors from tokens * Linting * linting * Using dict.insert_or_assign * Updated function name
* Adding new vocab class * Wrote the cpp Vocab class * Completed vocab class * Fixing style check * resolving PR comments * Using c::10 dict * Added tests for new functions * Fixing bug with specials tuple * Added factory method for vocab class * Annotated function return types * Using camel case for function names * Resolving PR comments * Fixing unit tests * Updated method names * Updated vocab with unk_token in specials and updated tests * Updated docstring to show example for Vocab class * Updated documentation for factory method * Resolving PR comments * Disabling tests for Glove due to URL breakage * Reneabling glove tests * Updating test asset name
Codecov Report
@@ Coverage Diff @@
## release/0.7 #886 +/- ##
===============================================
+ Coverage 76.91% 77.02% +0.10%
===============================================
Files 42 44 +2
Lines 2946 3055 +109
===============================================
+ Hits 2266 2353 +87
- Misses 680 702 +22
Continue to review full report at Codecov.
|
|
Are unittests expected to fail here? |
Glove link was broken due to the upstream dependency. @Nayef211 should we disable the tests again? |
|
Yeah I'm not sure I'd be comfortable tagging a new version with failing tests. |
OK, let me send out a PR to disable those test. |
seemethere
approved these changes
Jul 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let's test those recent changes in master branch first. We probably can cut the branch by July 20, 2020.
cc @cpuhrsch @Nayef211