[doc] Fix to DDP tutorial #3120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/tutorials/3120
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 38b14d7 with merge base b465aa7 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
linkcheck can be ignored for now |
svekars
approved these changes
Oct 28, 2024
c-p-i-o
force-pushed
the
chirag/fix-ddp-tutorial
branch
2 times, most recently
from
70862b0
to
4413dc4
Compare
c-p-i-o
force-pushed
the
chirag/fix-ddp-tutorial
branch
3 times, most recently
from
3db89e9
to
68f865f
Compare
Summary: 1. Add "set_device" call to keep things consistent between all DDP tutorials. This was inspired by the following change in the PyTorch repo: pytorch/examples#1285 (review) 2. Fix up the tutorial and add additional prints when the model exits. Test Plan: Ran tutorial with the applied changes and we see: """ Running basic DDP example on rank 3. Running basic DDP example on rank 1. Running basic DDP example on rank 2. Running basic DDP example on rank 0. Finished running basic DDP example on rank 0. Finished running basic DDP example on rank 1. Finished running basic DDP example on rank 3. Finished running basic DDP example on rank 2. Running DDP checkpoint example on rank 2. Running DDP checkpoint example on rank 1. Running DDP checkpoint example on rank 0. Running DDP checkpoint example on rank 3. Finished DDP checkpoint example on rank 0. Finished DDP checkpoint example on rank 3. Finished DDP checkpoint example on rank 1. Finished DDP checkpoint example on rank 2. Running DDP with model parallel example on rank 0. Running DDP with model parallel example on rank 1. Finished running DDP with model parallel example on rank 0. Finished running DDP with model parallel example on rank 1. """
c-p-i-o
force-pushed
the
chirag/fix-ddp-tutorial
branch
from
68f865f
to
d0e39c4
Compare
svekars
added a commit
that referenced
this pull request
Oct 31, 2024
Summary: 1. Add "set_device" call to keep things consistent between all DDP tutorials. This was inspired by the following change in the PyTorch repo: pytorch/examples#1285 (review) 2. Fix up the tutorial and add additional prints when the model exits. Test Plan: Ran tutorial with the applied changes. """ Co-authored-by: Svetlana Karslioglu <svekars@meta.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This was inspired by the following change in the PyTorch repo: Update DDP tutorial for the correct order of set_device examples#1285 (review)
Test Plan:
Ran tutorial with the applied changes and we see:
Fixes #ISSUE_NUMBER
Description
Checklist