Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[doc] Fix to DDP tutorial #3120

Merged
merged 3 commits into from
Oct 30, 2024
Merged

[doc] Fix to DDP tutorial #3120

merged 3 commits into from
Oct 30, 2024

Commits on Oct 29, 2024

  1. [doc] minor fixups to DDP tutorial

    Summary:
    1. Add "set_device" call to keep things consistent between all DDP
    tutorials.
    This was inspired by the following change in the PyTorch repo:
    pytorch/examples#1285 (review)
    2. Fix up the tutorial and add additional prints when the model exits.
    
    Test Plan:
    Ran tutorial with the applied changes and we see:
    """
    Running basic DDP example on rank 3.
    Running basic DDP example on rank 1.
    Running basic DDP example on rank 2.
    Running basic DDP example on rank 0.
    Finished running basic DDP example on rank 0.
    Finished running basic DDP example on rank 1.
    Finished running basic DDP example on rank 3.
    Finished running basic DDP example on rank 2.
    Running DDP checkpoint example on rank 2.
    Running DDP checkpoint example on rank 1.
    Running DDP checkpoint example on rank 0.
    Running DDP checkpoint example on rank 3.
    Finished DDP checkpoint example on rank 0.
    Finished DDP checkpoint example on rank 3.
    Finished DDP checkpoint example on rank 1.
    Finished DDP checkpoint example on rank 2.
    Running DDP with model parallel example on rank 0.
    Running DDP with model parallel example on rank 1.
    Finished running DDP with model parallel example on rank 0.
    Finished running DDP with model parallel example on rank 1.
    """
    c-p-i-o committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    d0e39c4 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    e865c2d View commit details
    Browse the repository at this point in the history

Commits on Oct 30, 2024

  1. Configuration menu
    Copy the full SHA
    38b14d7 View commit details
    Browse the repository at this point in the history