fix submodule imports by importing functions directly #6162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: fixes two sporadic issues from missing attributes: - breaking circular imports - submodule not being imported explicitly Reviewed By: ehhuang Differential Revision: D37071652 fbshipit-source-id: 7566952e748cc7cca8de9cf31eeb9f25d3b047ae
|
Did the lint_c binary changed? This seems unrelated to this PR.
|
|
They landed the diff so the cherry-pick PR is #6188. Let's see if the weird lint_c error appears over there |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
fixes two sporadic issues from missing attributes:
Reviewed By: ehhuang
Differential Revision: D37071652