Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FBcode->GH] fix submodule imports by importing functions directly #6188

Merged
merged 1 commit into from
Jun 22, 2022

Conversation

NicolasHug
Copy link
Member

Summary:
fixes two sporadic issues from missing attributes:

  • breaking circular imports
  • submodule not being imported explicitly

Reviewed By: ehhuang

Differential Revision: D37071652

fbshipit-source-id: 0680f098384b0fd21076339750e9d1a96186ede3

Summary:
fixes two sporadic issues from missing attributes:

- breaking circular imports
- submodule not being imported explicitly

Reviewed By: ehhuang

Differential Revision: D37071652

fbshipit-source-id: 0680f098384b0fd21076339750e9d1a96186ede3
Copy link
Contributor

@datumbox datumbox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. The breakages are unrelated.

@datumbox datumbox merged commit 59c4de9 into pytorch:main Jun 22, 2022
@github-actions
Copy link

Hey @datumbox!

You merged this PR, but no labels were added. The list of valid labels is available at https://github.com/pytorch/vision/blob/main/.github/process_commit.py

@datumbox datumbox added code quality other if you have no clue or if you will manually handle the PR in the release notes labels Jun 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla signed code quality other if you have no clue or if you will manually handle the PR in the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants