migrate cmake workflows from CircleCI to GHA #7417
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/vision/7417
Note: Links to docs will display an error until the docs builds have been completed. ❌ 3 New FailuresAs of commit 79ae3e6: NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This reverts commit f9c371c.
pmeier
changed the title
| if [[ ${{ matrix.gpu-arch-type }} == cuda ]]; then | ||
| export CU_VERSION=cu$(echo ${{ matrix.gpu-arch-version }} | sed 's/\.//') | ||
| echo CU_VERSION="${CU_VERSION}" | ||
| packaging/windows/internal/cuda_install.bat | ||
| fi |
There was a problem hiding this comment.
There was a problem hiding this comment.
HI @pmeir yes totally. However I think we should ship this PR for now calling packaging/windows/internal/cuda_install.bat . I will create new AMI and test it. Once new AMI is built we can remove this change.
| @@ -0,0 +1,124 @@ | |||
| #!/usr/bin/env bash | |||
There was a problem hiding this comment.
This is mostly https://github.com/pytorch/vision/blob/main/packaging/build_cmake.sh with all the slug taken out.
| popd | ||
|
|
||
| # This was only needed for the tracing above | ||
| pip uninstall -y torchvision |
There was a problem hiding this comment.
Probably not needed, but we are making sure here that we don't need to have a torchvision Python install for anything below.
|
All CMake workflows on GHA are green now: https://github.com/pytorch/vision/actions/runs/5033885907/jobs/9028384793 🎉 Do we want to have a grade period here, where we run the builds on CircleCI and GHA? IMO, we don't need to, since they were mostly unmaintained and we thoroughly tested the GHA builds in the process of migrating them. |
|
Hey @pmeier! You merged this PR, but no labels were added. The list of valid labels is available at https://github.com/pytorch/vision/blob/main/.github/process_commit.py |
Follow-up to pytorch/vision#7417 (comment). Untested, but should work.
Summary: Co-authored-by: Andrey Talman <atalman@fb.com> Reviewed By: vmoens Differential Revision: D46314040 fbshipit-source-id: 30d32462ee3e6615a23b6914b4d62e6e23070cec
cc @seemethere