Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kill CircleCI #7611

Merged
merged 9 commits into from
May 24, 2023
Merged

kill CircleCI #7611

merged 9 commits into from
May 24, 2023

Conversation

pmeier
Copy link
Collaborator

@pmeier pmeier commented May 20, 2023

Closes #7405. There are currently three groups still running on CircleCI:

  • CMake: migration is happening in migrate cmake workflows from CircleCI to GHA #7417. Since that one is not merged yet, I'm marking this PR as draft to avoid accidental merges.
  • Docker build: Closes Do we need the Docker CI job? #7610. As explained there, this job isn't running currently and no longer has a purpose.
  • Lint: This is a self-serving job to check that the config.yml is in sync with the template config.yml.in and the render script regenerate.py. This is moot if we kill CircleCi.

cc @seemethere

@pytorch-bot
Copy link

pytorch-bot bot commented May 20, 2023

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/vision/7611

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure

As of commit 0dff39f:

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pmeier
Copy link
Collaborator Author

pmeier commented May 20, 2023

dcba188 also cleans up the packaging folder that currently still contains a lot of scripts that were only used on CircleCI.

@pmeier pmeier marked this pull request as ready for review May 22, 2023 08:59
@pmeier pmeier marked this pull request as draft May 22, 2023 09:01
Copy link
Member

@NicolasHug NicolasHug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stamping assuming #7417 is green and GTG, thanks a lot Philip!

@pmeier pmeier requested a review from atalman May 22, 2023 13:46
@pmeier pmeier marked this pull request as ready for review May 23, 2023 13:27
@pmeier pmeier merged commit 4125d3a into pytorch:main May 24, 2023
@pmeier pmeier deleted the kill-circleci branch May 24, 2023 14:43
@github-actions
Copy link

Hey @pmeier!

You merged this PR, but no labels were added. The list of valid labels is available at https://github.com/pytorch/vision/blob/main/.github/process_commit.py

facebook-github-bot pushed a commit that referenced this pull request May 31, 2023
Reviewed By: vmoens

Differential Revision: D46314039

fbshipit-source-id: 39a5a9e898a63beeca5ff579ed4d8bf809949311
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Do we need the Docker CI job? CircleCI to GitHub Actions tracker
4 participants