-
Notifications
You must be signed in to change notification settings - Fork 7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enable Windows GPU CI on GHA #7498
Conversation
nvjpeg is now there: https://github.com/pytorch/vision/actions/runs/4849919333/jobs/8642356230#step:9:233 However, it seems something is off with the path as we cannot load the |
This reverts commit 6b9db82.
In c12e4f7 I removed the Windows GPU tests from CircleCI. Although we usually had a grace period, I don't think we need one here. The grace period for the CPU workflow is already over (#7526) and this PR only enables the GPU runs. If the CI is green here, I don't expect any regressions for this later on. LMK if you think otherwise so I can revert that commit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Philip
However, it seems something is off with the path as we cannot load the image.pyd
Just to confirm, is this comment still relevant? I'm seeing the test/test_image.py::test_decode_jpeg_cuda
tests properly passing (as well as the cuda ones in test_models.py
) so as far as tests go, this PR LGTM.
No, comment is outdated. This was fixed in 5c0da2e. |
Hey @pmeier! You merged this PR, but no labels were added. The list of valid labels is available at https://github.com/pytorch/vision/blob/main/.github/process_commit.py |
Reviewed By: vmoens Differential Revision: D45522826 fbshipit-source-id: fb832f29c09ade1d7a796ebf31d35d74ed600aff
Follow-up to #7475 (comment).
cc @seemethere