Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve smoke test #7550

Merged
merged 3 commits into from
May 2, 2023
Merged

improve smoke test #7550

merged 3 commits into from
May 2, 2023

Conversation

pmeier
Copy link
Collaborator

@pmeier pmeier commented May 1, 2023

Without this, an incorrect setup for nvjpeg will not be detected by the smoke test. I stumbled over this in #7498.

@pmeier pmeier requested a review from atalman May 1, 2023 21:11
@pytorch-bot
Copy link

pytorch-bot bot commented May 1, 2023 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/vision/7550

Note: Links to docs will display an error until the docs builds have been completed.

❗ 2 Active SEVs

There are 2 currently active SEVs. If your PR is affected, please view them below:

❌ 16 New Failures

As of commit 5f138fa:

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

pmeier
pmeier commented May 1, 2023
View reviewed changes
test/smoke_test.py
@@ -1,13 +1,11 @@
"""Run smoke tests"""

import os
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Driveby: remove unused import. Same below

NicolasHug
NicolasHug reviewed May 2, 2023
View reviewed changes
Copy link
Member

@NicolasHug NicolasHug left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Philip, are we sure that the smoke_test.py script is always going to be run on a machine with CUDA support? EDIT: call is protected, not a problem

test/smoke_test.py Outdated Show resolved Hide resolved
NicolasHug
NicolasHug approved these changes May 2, 2023
View reviewed changes
Copy link
Member

@NicolasHug NicolasHug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with minor comment above

@pmeier pmeier changed the title add decode_jpeg_cuda to smoke test improve smoke test May 2, 2023
@pmeier pmeier merged commit 6381f7b into pytorch:main May 2, 2023
@pmeier pmeier deleted the improve-smoke-test branch May 2, 2023 11:04
@github-actions
Copy link

github-actions bot commented May 2, 2023

Hey @pmeier!

You merged this PR, but no labels were added. The list of valid labels is available at https://github.com/pytorch/vision/blob/main/.github/process_commit.py

facebook-github-bot pushed a commit that referenced this pull request May 15, 2023
@NicolasHug @facebook-github-bot
[fbsync] improve smoke test (#7550)
d232200 
Reviewed By: vmoens

Differential Revision: D45522829

fbshipit-source-id: aba08b74b26aa59111f68e50e11ab3a36abe1980
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NicolasHug NicolasHug NicolasHug approved these changes

@atalman atalman Awaiting requested review from atalman

Assignees
No one assigned
Labels
cla signed enhancement module: tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pmeier @NicolasHug @facebook-github-bot