New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port remaining transforms tests #7954

Merged

pmeier merged 26 commits into pytorch:main from pmeier:port

Sep 26, 2023

Collaborator

pmeier commented Sep 11, 2023 •

edited by pytorch-bot bot

Loading

I've tried to make the individual commits as atomic as possible. Meaning, you can probably review the commits one by one.

pmeier added 4 commits

September 11, 2023 11:00


          port tests for F.equalize and transforms.RandomEqualize

348231d


          port tests for F.uniform_temporal_subsample and transforms.UniformTem…

…poralSubsample


          port tests for F.normalize and transforms.Normalize

9b5b7c4


          cleanup

c69eb28

pmeier added module: transforms module: tests labels

pytorch-bot bot commented Sep 11, 2023 •

edited

Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/vision/7954

📄 Preview Python docs built from this PR

Note: Links to docs will display an error until the docs builds have been completed.

⏳ No Failures, 1 Pending

As of commit 7902956 with merge base 997384c ():
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

facebook-github-bot added the cla signed label

pmeier commented

View reviewed changes

test/test_transforms_v2_refactored.py Outdated Show resolved Hide resolved

pmeier added 15 commits

September 11, 2023 13:07


          port tests for F.clamp_bounding_boxes and transforms.ClampBoundingBoxes

0a6413a


          fix normalize tests

227ca27


          port tests for F.invert and transforms.RandomInvert

734d0b7


          add new tests for F.posterize and transforms.RandomPosterize

845ac36


          add new tests for F.solarize and transforms.RandomSolarize

472ec15


          add new tests for F.autocontrast and transforms.RandomAutocontrast

41cfdad


          add new tests for F.adjust_sharpness and transforms.RandomAdjustSharp…

40f21b2

…ness


          add new tests for F.adjust_contrast

635c2c4


          add new tests for F.adjust_gamma

257d0f4


          add new tests for F.adjust_hue

c959590


          add new tests for F.adjust_saturation

8cd9fdf


          cleanup

555d44a


          fix normalize

0683b1c


          add tests for five / ten crop

01992d3


          cleanup

775e5ec

pmeier marked this pull request as ready for review

September 13, 2023 07:44

pmeier requested a review from NicolasHug

September 13, 2023 07:44

Collaborator Author

pmeier commented Sep 13, 2023

As of 775e5ec, the old KernelInfo / DispatcherInfo architecture is dead and all tests that depend on it are removed. Since these parts were strongly tied to the functional tests, there are still some legacy transforms test to port. I'll get to that in a separate PR, since this one is already large enough as is.

pmeier mentioned this pull request

port sample input smoke test #7962

Merged

pmeier mentioned this pull request

port tests for RandomPhotometricDistort #7973

Merged

NicolasHug reviewed

View reviewed changes

Member

NicolasHug left a comment

Thanks @pmeier, made a first pass on the the first half of the tests

test/test_transforms_v2_refactored.py Outdated Show resolved Hide resolved

test/test_transforms_v2_refactored.py Outdated Show resolved Hide resolved

test/test_transforms_v2_refactored.py Outdated Show resolved Hide resolved

test/test_transforms_v2_refactored.py

		self._assert_is_standard_normal_distributed(output)


		class TestClampBoundingBoxes:

Member

NicolasHug Sep 25, 2023

Maybe we'll want a sanity check for this one (that the bbox is indeed clamped). But I guess this can come in another PR

test/test_transforms_v2_refactored.py Outdated Show resolved Hide resolved

pmeier added 4 commits

September 26, 2023 10:59


          add normalize correctness test

a845f30


          localize five ten crop special cases

bcc8710


          Merge branch 'main' into port

c2a60ae


          Merge branch 'main' into port

bc9b68e

NicolasHug approved these changes

View reviewed changes

Member

NicolasHug left a comment

Thanks @pmeier, some last comments but LGTM

test/test_transforms_v2_refactored.py Outdated Show resolved Hide resolved

test/test_transforms_v2_refactored.py Show resolved Hide resolved

test/test_transforms_v2_refactored.py Show resolved Hide resolved

test/test_transforms_v2_refactored.py Outdated Show resolved Hide resolved

test/test_transforms_v2_refactored.py Outdated Show resolved Hide resolved

test/test_transforms_v2_refactored.py Outdated Show resolved Hide resolved

pmeier added 3 commits

September 26, 2023 12:41


          fix solarize correctness

64737ba


          fix five / ten crop

58d6ecb


          simplify equalize correctness

pmeier merged commit 1a9ff0d into pytorch:main

54 of 62 checks passed

github-actions bot commented Sep 26, 2023

You merged this PR, but no labels were added. The list of valid labels is available at https://github.com/pytorch/vision/blob/main/.github/process_commit.py

pmeier deleted the port branch

September 26, 2023 11:18

facebook-github-bot pushed a commit that referenced this pull request


          [fbsync] Port remaining transforms tests (#7954)

Reviewed By: vmoens

Differential Revision: D50789097

fbshipit-source-id: bdcb58bb2ca49258dc9621438b193b2b23f7efa3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla signed module: tests module: transforms