-
Notifications
You must be signed in to change notification settings - Fork 7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
port sample input smoke test #7962
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/vision/7962
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New Failure, 5 Unrelated FailuresAs of commit 99e5506 with merge base f33e387 (): FLAKY - The following jobs failed but were likely due to flakiness present on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
If we merge #8001 before this one, we can completely get rid of the old test here. |
This reverts commit 1173704.
Sorry about the commit and revert, I was on the wrong branch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot @pmeier
Some benchmarks:
Although we now test multiple configurations per transform, we ultimately end up (insignificantly on our scales) faster than before, because we removed some duplication between the legacy and current tests as well as doing some refactoring that was not possible in the legacy tests. |
Hey @pmeier! You merged this PR, but no labels were added. The list of valid labels is available at https://github.com/pytorch/vision/blob/main/.github/process_commit.py |
Summary: Co-authored-by: Nicolas Hug <contact@nicolas-hug.com> Reviewed By: vmoens Differential Revision: D50789108 fbshipit-source-id: cb38c29356d6ffdba86819bc65b44d2081833d28
Builds on top of #7954. I'll rebase after that is merged.
cc @vfdev-5