Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose transforms.v2 utils for writing custom transforms. #8670

Merged
merged 2 commits into from
Oct 3, 2024

Conversation

venkatram-dev
Copy link
Contributor

@venkatram-dev venkatram-dev commented Oct 3, 2024

#7785 (comment)

pytest test/test_transforms_v2.py -vvv -k test_functional

test/test_transforms_v2.py::TestQuerySize::test_functional[pure_tensor] PASSED                                         [ 99%]
test/test_transforms_v2.py::TestQuerySize::test_functional[tv_tensor_image] PASSED                                     [ 99%]
test/test_transforms_v2.py::TestQuerySize::test_functional[pil_image] PASSED                                           [ 99%]
test/test_transforms_v2.py::TestQuerySize::test_functional[tv_tensor_video] PASSED                                     [ 99%]
test/test_transforms_v2.py::TestQuerySize::test_functional[tv_tensor_mask] PASSED                                      [ 99%]
test/test_transforms_v2.py::TestQuerySize::test_functional_mixed_types[pure_tensor] PASSED                             [ 99%]
test/test_transforms_v2.py::TestQuerySize::test_functional_mixed_types[tv_tensor_image] PASSED                         [ 99%]
test/test_transforms_v2.py::TestQuerySize::test_functional_mixed_types[pil_image] PASSED                               [ 99%]
test/test_transforms_v2.py::TestQuerySize::test_functional_mixed_types[tv_tensor_video] PASSED                         [ 99%]
test/test_transforms_v2.py::TestQuerySize::test_functional_mixed_types[tv_tensor_mask] PASSED                          [100%]


cc @vfdev-5

Copy link

pytorch-bot bot commented Oct 3, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/vision/8670

Note: Links to docs will display an error until the docs builds have been completed.

❌ 4 New Failures

As of commit 1f24d8f with merge base 9832166 (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@venkatram-dev
Copy link
Contributor Author

pytest test/test_transforms_v2.py -vvv -k test_functional

test/test_transforms_v2.py::TestQuerySize::test_functional[pure_tensor] PASSED                                         [ 99%]
test/test_transforms_v2.py::TestQuerySize::test_functional[tv_tensor_image] PASSED                                     [ 99%]
test/test_transforms_v2.py::TestQuerySize::test_functional[pil_image] PASSED                                           [ 99%]
test/test_transforms_v2.py::TestQuerySize::test_functional[tv_tensor_video] PASSED                                     [ 99%]
test/test_transforms_v2.py::TestQuerySize::test_functional[tv_tensor_mask] PASSED                                      [ 99%]
test/test_transforms_v2.py::TestQuerySize::test_functional_mixed_types[pure_tensor] PASSED                             [ 99%]
test/test_transforms_v2.py::TestQuerySize::test_functional_mixed_types[tv_tensor_image] PASSED                         [ 99%]
test/test_transforms_v2.py::TestQuerySize::test_functional_mixed_types[pil_image] PASSED                               [ 99%]
test/test_transforms_v2.py::TestQuerySize::test_functional_mixed_types[tv_tensor_video] PASSED                         [ 99%]
test/test_transforms_v2.py::TestQuerySize::test_functional_mixed_types[tv_tensor_mask] PASSED                          [100%]

@NicolasHug NicolasHug changed the title make_public_query_size Expose transforms.v2 utils for writing custom transforms. Oct 3, 2024
@NicolasHug
Copy link
Member

Thanks for the initial PR @venkatram-dev . Note that tests were failing for different reasons, the main one being that query_size was imported from the wrong module (I assume your code changed since you last tested?)

I fixed and cleaned up the tests, added some more test cases, and exposed a few more utils. Thank you!

@NicolasHug NicolasHug merged commit f0ed07d into pytorch:main Oct 3, 2024
71 of 75 checks passed
NicolasHug added a commit to NicolasHug/vision that referenced this pull request Oct 3, 2024
…8670)

Co-authored-by: Nicolas Hug <contact@nicolas-hug.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants