-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix reference images for pillow 9.4 #84
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Darn it, I was going to do this. I was going to make a new compare_or_recreate_image
function that recreated the test images if they didn't already exist (fail the test on recreation).
Anyway, I guess this looks good. Could/should the areas that you refactored out be fixtures? I guess it doesn't matter.
Yes, I tried this also, but I wanted this to be an option to pytest, but I couldn't find an elegant solution to have the file being saved on failure... Next time maybe.
I think they don't need to be. My hope is that by exposing those at the beginning of the file will promote the use of existing areas instead of creating new ones every time. |
I thought it would require the developer to delete the failing images, rerun tests which generate the images but still fail, then rerun the tests which should now pass. |
My commit message is wrong, but the change is correct. I switched Python 3.7 to Python 3.8 in CI. Should I maybe bump 3.9 to 3.11? |
This PR should fix some reference images for compatibility with pillow 9.4