Cleanup tests

[mraspaud]

As a continuation of #84 , some more grunt work to refactor and cleanup the tests.

• Closes #xxxx
• Tests added
• Tests passed
• Passes git diff origin/main **/*py | flake8 --diff
• Fully documented

[mraspaud]

Got the file under 2000 lines, 🎉

[coveralls]

Coverage: 94.477% (-0.6%) from 95.051% when pulling 7effb22 on mraspaud:refactor-pycoast-tests into 8589e6d on pytroll:main.

[mraspaud]

@djhoese I can't seem to figure out how to fix the sphinx error. I added the pytest-lazy-fixture to the docs, but the build doesn't seem to catch it. Could it be that the build image is being cached?

[djhoese]

Check how I do it in satpy. I think I had to load pytest_lazy_fixture directly and use tha5, not the pytest.plugin version.

[mraspaud]

@djhoese thanks! trying this now.

[djhoese]

If the coverage loss is purely just the changing lines in the test_pycoast.py module then 👌. If it is any part of the contour writer modules then not 👌.

Nice job. Looks much better.

[mraspaud]

I haven't changed anything in the production code, and didn't remove any test functionality, so my guess is that the coverage drop is due to fewer test lines and more production lines. Maybe we should remove the tests from the coverage computation?

[djhoese]

Maybe we should remove the tests from the coverage computation?

I'm not a fan of this. I feel like it is a quick identifier for when a typo makes a test not run or a utility/helper in a test isn't used anymore.

[djhoese]

Coveralls shows that the p_file_path fixture is never used it seems.

[mraspaud]

Coveralls shows that the p_file_path fixture is never used it seems.

Indeed, removing it.