-
Notifications
You must be signed in to change notification settings - Fork 300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add image comparison behave tests #2912
Conversation
The branch for this PR includes 322 MiB in data (8 PNG files), added in commit 1367072. We should probably upload those files somewhere (zenodo?) and then include code to download them on-the-fly, as to not pollute the git repository with large binary files. This may need rewriting the commit history? |
Yes, I think getting completely rid of the images from the repo requires rewriting the git history on force-pushing. |
If we remove the images in a dedicated commit, then squash the commits before merge, would that be enough to remove the images from the git history? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2912 +/- ##
==========================================
+ Coverage 95.97% 96.05% +0.07%
==========================================
Files 368 373 +5
Lines 53973 54406 +433
==========================================
+ Hits 51801 52259 +458
+ Misses 2172 2147 -25
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
Pull Request Test Coverage Report for Build 11075540122Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
Related to pytroll/image-comparison-tests#2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
start behave test
Starting to clone and test the repository pytroll/satpy |
The testing process was executed successfully. See the test results for this pull request here! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
start behave test
Starting to clone and test the repository pytroll/satpy |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
start behave test
A job is already running for this repository. Please wait for the current job to finish. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
start behave test
Starting to clone and test the repository pytroll/satpy |
The testing process was executed successfully. See the test results for this pull request here! |
The code under and |
Delete duplicate behave tests. Already present in Satpy PR at pytroll/satpy#2912
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
start behave test
Starting to clone and test the repository pytroll/satpy |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
start behave test
A job is already running for this repository. Please wait for the current job to finish. |
An error occurred during the process. |
1 similar comment
An error occurred during the process. |
Error while cloning the repository: Error while cloning the repository: Command '['docker', 'run', '--name', 'clone-repo-image', '-v', '/home/imagetester/pull_request_pull-branch:/app', '-v', '/home/imagetester/pytroll-image-comparison-tests/data:/app/ext_data', 'python:3.10-slim', 'bash', '-c', 'touch /app/output.log && apt-get update >> /app/output.log 2>&1 && apt-get install -y git libgl1-mesa-glx libglib2.0-0 python3-venv >> /app/output.log 2>&1 && python3 -m venv /app/venv >> /app/output.log 2>&1 && /app/venv/bin/pip install behave Pillow pytest numpy opencv-python dask netcdf4 h5netcdf >> /app/output.log 2>&1 && git clone https://[REDACTED]@github.com/KatrinPoepp/satpy.git --branch pull-branch /app/repository >> /app/output.log 2>&1 && source /app/venv/bin/activate && pip install -e /app/repository >> /app/output.log 2>&1 && source /app/venv/bin/activate && cd /app/repository/satpy/tests/behave && behave >> /app/output.log 2>&1 || true && chown -R 1005:1005 /app >> /app/output.log 2>&1']' returned non-zero exit status 137. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
start behave test
Starting to clone and test the repository pytroll/satpy |
The testing process was executed successfully. See the test results for this pull request here! |
Replaced by #2999 |
Pytroll image comparison dev behave tests as PR. This method of code transfer was proposed by Martin Raspaud.
Documentation for the behave tests will be provided with the rest of the project code.