-
Notifications
You must be signed in to change notification settings - Fork 300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Accsos image comparison tests #2999
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
start behave test
Starting to clone and test the repository pytroll/satpy |
The testing process was executed successfully. See the test results for this pull request here! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2999 +/- ##
==========================================
+ Coverage 96.08% 96.10% +0.01%
==========================================
Files 377 377
Lines 55155 55162 +7
==========================================
+ Hits 52997 53012 +15
+ Misses 2158 2150 -8
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
start behave test
Starting to clone and test the repository pytroll/satpy |
An error occurred during the process. |
1 similar comment
An error occurred during the process. |
Error while cloning the repository: Error while cloning the repository: Command '['docker', 'run', '--name', 'clone-repo-image', '-v', '/home/imagetester/pull_request_katrins-behave-tests:/app', '-v', '/home/imagetester/pytroll-image-comparison-tests/data:/app/ext_data', 'python:3.10-slim', 'bash', '-c', 'touch /app/output.log && apt-get update >> /app/output.log 2>&1 && apt-get install -y git libgl1-mesa-glx libglib2.0-0 python3-venv >> /app/output.log 2>&1 && python3 -m venv /app/venv >> /app/output.log 2>&1 && /app/venv/bin/pip install behave Pillow pytest numpy opencv-python dask netcdf4 h5netcdf >> /app/output.log 2>&1 && git clone https://[REDACTED]@github.com/gerritholl/satpy.git --branch katrins-behave-tests /app/repository >> /app/output.log 2>&1 && source /app/venv/bin/activate && pip install -e /app/repository >> /app/output.log 2>&1 && source /app/venv/bin/activate && cd /app/repository/satpy/tests/behave && behave >> /app/output.log 2>&1 || true && chown -R 1005:1005 /app >> /app/output.log 2>&1']' returned non-zero exit status 137. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
start behave test
Starting to clone and test the repository pytroll/satpy |
The testing process was executed successfully. See the test results for this pull request here! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
start behave test
Starting to clone and test the repository pytroll/satpy |
Pull Request Test Coverage Report for Build 12180088803Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
The testing process was executed successfully. See the test results for this pull request here! |
52e3d04
to
9935d46
Compare
Move the reference imagery creation script to the utils/ directory. Delete the not-needed image modification script. Simplify and generalise the reference imagery creation script a bit.
Read reference images externally, like the input data.
9935d46
to
22c5c55
Compare
I think the satpy part of this is ready to merge. We can generalise the image generation script and cover more readers and areas later. The interaction with the EWC is covered by pytroll/image-comparison-tests#2, which is already deployed experimentally although it still needs some work. But we can start using it and continue testing as soon as this is merged into main. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
start behave test
Starting to clone and test the repository pytroll/satpy |
The testing process was executed successfully. See the test results for this pull request here! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
start behave test
Starting to clone and test the repository pytroll/satpy |
The testing process was executed successfully. See the test results for this pull request here! |
pre-commit.ci autofix |
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good for now!
Add image comparison tests from the Accso delivery.
Needs pytroll/image-comparison-tests#2 to run.
This is a reboot of #2912.
AUTHORS.md
if not there already