Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Accsos image comparison tests #2999

Merged
merged 14 commits into from
Dec 5, 2024

Conversation

gerritholl
Copy link
Member

Add image comparison tests from the Accso delivery.

Needs pytroll/image-comparison-tests#2 to run.

This is a reboot of #2912.

  • Closes #xxxx
  • Tests added
  • Fully documented
  • Add your name to AUTHORS.md if not there already

Copy link
Member Author

@gerritholl gerritholl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

start behave test

@rymdulf
Copy link

rymdulf commented Nov 22, 2024

Starting to clone and test the repository pytroll/satpy

@rymdulf
Copy link

rymdulf commented Nov 22, 2024

The testing process was executed successfully. See the test results for this pull request here!

Copy link

codecov bot commented Nov 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.10%. Comparing base (fa56be5) to head (f92ceaa).
Report is 42 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2999      +/-   ##
==========================================
+ Coverage   96.08%   96.10%   +0.01%     
==========================================
  Files         377      377              
  Lines       55155    55162       +7     
==========================================
+ Hits        52997    53012      +15     
+ Misses       2158     2150       -8     
Flag Coverage Δ
behaviourtests 3.94% <ø> (-0.01%) ⬇️
unittests 96.19% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member Author

@gerritholl gerritholl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

start behave test

@rymdulf
Copy link

rymdulf commented Nov 22, 2024

Starting to clone and test the repository pytroll/satpy

@rymdulf
Copy link

rymdulf commented Nov 22, 2024

An error occurred during the process.

1 similar comment
@rymdulf
Copy link

rymdulf commented Nov 22, 2024

An error occurred during the process.

@rymdulf
Copy link

rymdulf commented Nov 22, 2024

Error while cloning the repository: Error while cloning the repository: Command '['docker', 'run', '--name', 'clone-repo-image', '-v', '/home/imagetester/pull_request_katrins-behave-tests:/app', '-v', '/home/imagetester/pytroll-image-comparison-tests/data:/app/ext_data', 'python:3.10-slim', 'bash', '-c', 'touch /app/output.log && apt-get update >> /app/output.log 2>&1 && apt-get install -y git libgl1-mesa-glx libglib2.0-0 python3-venv >> /app/output.log 2>&1 && python3 -m venv /app/venv >> /app/output.log 2>&1 && /app/venv/bin/pip install behave Pillow pytest numpy opencv-python dask netcdf4 h5netcdf >> /app/output.log 2>&1 && git clone https://[REDACTED]@github.com/gerritholl/satpy.git --branch katrins-behave-tests /app/repository >> /app/output.log 2>&1 && source /app/venv/bin/activate && pip install -e /app/repository >> /app/output.log 2>&1 && source /app/venv/bin/activate && cd /app/repository/satpy/tests/behave && behave >> /app/output.log 2>&1 || true && chown -R 1005:1005 /app >> /app/output.log 2>&1']' returned non-zero exit status 137.

Copy link
Member Author

@gerritholl gerritholl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

start behave test

@rymdulf
Copy link

rymdulf commented Nov 22, 2024

Starting to clone and test the repository pytroll/satpy

@rymdulf
Copy link

rymdulf commented Nov 22, 2024

The testing process was executed successfully. See the test results for this pull request here!

Copy link
Member Author

@gerritholl gerritholl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

start behave test

@rymdulf
Copy link

rymdulf commented Nov 22, 2024

Starting to clone and test the repository pytroll/satpy

@coveralls
Copy link

coveralls commented Nov 22, 2024

Pull Request Test Coverage Report for Build 12180088803

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 96.208%

Totals Coverage Status
Change from base Build 11936881763: 0.02%
Covered Lines: 53256
Relevant Lines: 55355

💛 - Coveralls

@rymdulf
Copy link

rymdulf commented Nov 22, 2024

The testing process was executed successfully. See the test results for this pull request here!

@gerritholl gerritholl force-pushed the katrins-behave-tests branch 2 times, most recently from 52e3d04 to 9935d46 Compare November 22, 2024 14:18
@gerritholl gerritholl marked this pull request as ready for review November 22, 2024 14:49
@gerritholl
Copy link
Member Author

I think the satpy part of this is ready to merge. We can generalise the image generation script and cover more readers and areas later.

The interaction with the EWC is covered by pytroll/image-comparison-tests#2, which is already deployed experimentally although it still needs some work. But we can start using it and continue testing as soon as this is merged into main.

Copy link
Member Author

@gerritholl gerritholl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

start behave test

@rymdulf
Copy link

rymdulf commented Nov 22, 2024

Starting to clone and test the repository pytroll/satpy

@rymdulf
Copy link

rymdulf commented Nov 22, 2024

The testing process was executed successfully. See the test results for this pull request here!

Copy link
Member Author

@gerritholl gerritholl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

start behave test

@rymdulf
Copy link

rymdulf commented Nov 22, 2024

Starting to clone and test the repository pytroll/satpy

@rymdulf
Copy link

rymdulf commented Nov 22, 2024

The testing process was executed successfully. See the test results for this pull request here!

@mraspaud
Copy link
Member

mraspaud commented Dec 5, 2024

pre-commit.ci autofix

@mraspaud mraspaud added the enhancement code enhancements, features, improvements label Dec 5, 2024
Copy link
Member

@mraspaud mraspaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good for now!

@mraspaud mraspaud merged commit 56b3341 into pytroll:main Dec 5, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement code enhancements, features, improvements
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

5 participants