-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MAINT: Fixes for NumPy deprecation and 3.10 #42
Conversation
I have a feeling |
- name: Manually install VTK wheel on 3.10 since it does not work locally | ||
run: | | ||
pip install --upgrade pip | ||
curl https://wheels.pyvista.org/vtk-9.1.0.dev0-cp310-cp310-macosx_12_0_x86_64.whl -o vtk-9.1.0.dev0-cp310-cp310-macosx_10_16_x86_64.whl | ||
pip install ./vtk-9.1.0.dev0-cp310-cp310-macosx_10_16_x86_64.whl | ||
if: ${{ matrix.os == 'macos-12' }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Locally on my 12.3 Monterey install I cannot reproduce this issue, but on GH actions there is some problem installing this wheel despite many attempts at debugging. So here I just hack the filename to make it seem like at 10_16 wheel so that pip
will install it.
It's a hack but I think it's acceptable since we want a 3.10 wheel for this package, and this hack can go away once VTK releases 9.2 with 3.10 wheels in the coming weeks (!?)
Finally green! |
@pyvista/developers this one is ready for review. It would be nice to merge this so that we could get 3.10 wheels on PyPi |
... I went a step further and just called
I also fixed some plain |
Yeah, that's what I had in mind.
Good idea, thanks. I wonder if we should define some more meaningful errors for these... not sure it's worth it for purity's sake. |
Seems like overkill. I doubt users will hit these very often... but moving to a more specific builtin error type seemed like a minimal amount of effort required to make it slightly better here. |
All green again, okay to merge @adeak ? |
Sorry, @larsoner, I can't review any of the CI changes :( The numpy part seems good to me. |
I think the CI stuff is necessary to get 3.10 support. If anyone else wants to look and finds problems, I'm happy to open another PR, or revert and try again! But in the meantime I'll go ahead and merge and cut a release to see if PyPi wheels show up. |
np.float
is just an alias forfloat
so avoid the deprecation warning about it.manylinux2014
for Python3.10 supportwheels.pyvistia.org
)FYI it would be good to merge this and cut a release since there are no Python 3.10 wheels for
pymeshfix
.