-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1476: Support double-byte chars for LEFT(),RIGHT(), LEN() and MID(). #1477
Conversation
I will add more tests for those functions if needed. |
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## master #1477 +/- ##
=======================================
Coverage 98.68% 98.68%
=======================================
Files 31 31
Lines 24274 24274
=======================================
Hits 23956 23956
Misses 210 210
Partials 108 108
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for your contribution.
Thank you for quick response! I have added some testing and xxxB(LENB/RIGHTB/MIDB) function code so let me make PR again. |
…ons LEFT,RIGHT, LEN and MID (qax-os#1477)
…ons LEFT,RIGHT, LEN and MID (qax-os#1477)
PR Details
Support double-byte characters support for string functions such as LEFT().
Description
Added double bytes chars support by using utf counting.
Related Issue
#1476
Motivation and Context
I was using Excel sheet that has Japanese characters in it, but those formulas were not supported at the moment,
How Has This Been Tested
Added testing
Types of changes
Checklist