Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1476: Test codes and Byte process #1478

Merged
merged 6 commits into from
Feb 20, 2023

Conversation

FlowingSPDG
Copy link
Contributor

PR Details

context: #1477 and #1476

Description

  • Fix LENB() and more byte-based string operations
  • Add testing

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov-commenter
Copy link

codecov-commenter commented Feb 20, 2023

Codecov Report

Merging #1478 (0797bf9) into master (983cd76) will increase coverage by 0.00%.
The diff coverage is 100.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@           Coverage Diff           @@
##           master    #1478   +/-   ##
=======================================
  Coverage   98.68%   98.69%           
=======================================
  Files          31       31           
  Lines       24274    24300   +26     
=======================================
+ Hits        23956    23982   +26     
  Misses        210      210           
  Partials      108      108           
Flag Coverage Δ
unittests 98.69% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
calc.go 99.03% <100.00%> (+<0.01%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@FlowingSPDG FlowingSPDG marked this pull request as ready for review February 20, 2023 07:03
@FlowingSPDG FlowingSPDG changed the title Draft: 1476: Test codes and Byte process 1476: Test codes and Byte process Feb 20, 2023
Copy link
Member

@xuri xuri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR. I've left a comment. Overwise, I think the TODO comments of the leftRight function can be removed now.

calc_test.go Outdated Show resolved Hide resolved
@xuri xuri added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Feb 20, 2023
Copy link
Member

@xuri xuri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you very much.

@xuri xuri merged commit f143dd5 into qax-os:master Feb 20, 2023
@FlowingSPDG FlowingSPDG deleted the 1476-left-right-double-chars branch February 20, 2023 16:43
xuri pushed a commit to JDavidVR/excelize that referenced this pull request Jul 11, 2023
jenbonzhang pushed a commit to jenbonzhang/excelize that referenced this pull request Oct 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants