-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for tableschema metadata #1003
Comments
Hi @JDziurlaj |
#987 seems to already be implemented, as you commented. I think the confusion comes down to the adage that "one man's data is another man's metadata". The table-schema is metadata about what the user is providing. What I am requesting here is another level above that, metadata about the table-schema itself. I can't speak to #972, we do not currently use foreign keys. |
Hi @JDziurlaj At the moment we're shortlisting potential candidates for this release cycle and I think there are ideas here that I'd like to raise with our sponsors as worth consideration. Please correct me on any of the below:
I think a hash and reporting of version (if there is not a 'right way to show this already in frictionless spec) are straightforward enough to do and something that I can raise with sponsors. If I've understood, there's a second issue here about the persistence of some properties from the original import to export. I'll look through to see what happens to existing metadata from import to export again, but if you had some examples of data that show this to post here, that might help speed things along for working out effort required. I can certainly look at where we might be able to lock things down further or perhaps not overwrite certain properties |
Hi @mattRedBox, You captured the essence of our request. A minor correction would be that metadata is lost whether or not the properties are 'locked' or not. Here is a Gist showing a There is metadata such as |
Hi @JDziurlaj |
Hi @JDziurlaj |
I would put it under the Table sidebar, much like Package has a Yes, you may use the Gists, they are publicly available. |
Ok thanks @JDziurlaj |
Looking to combine some of this work, the non-Data-Curator properties persistence, with: #988. |
… columns, tables or packages. Removed commented out code.
…side of app life. Corrected ids so unique.
…ackage properties when custom removed. Keep all preferences in column, table, packages to simplify synchronizing. Match for custom type only happens in rendering of view.
… for TableProperties as for PackageProperties.
…name is unique in preferences. Set max width for custom name (but still allow user to scroll full text.
…e, table and columns on export. Ensure custom names are not reserved by current package,table or column properties.
… 'reserved' properties. Fixed in export so store properties not mutated.
Hi @JDziurlaj
|
So to be clear, you are saying that custom properties are or are not maintained through the Import Package/Column properties pulldown function? |
Hi @JDziurlaj
I've lodged an issue to address the use of 'toggling' certain conventional/expected behaviours. It could be that we add to this list, say, a preference toggle that:
|
… columns, tables or packages. Removed commented out code.
…side of app life. Corrected ids so unique.
…ackage properties when custom removed. Keep all preferences in column, table, packages to simplify synchronizing. Match for custom type only happens in rendering of view.
… for TableProperties as for PackageProperties.
…name is unique in preferences. Set max width for custom name (but still allow user to scroll full text.
…e, table and columns on export. Ensure custom names are not reserved by current package,table or column properties.
… 'reserved' properties. Fixed in export so store properties not mutated.
We can now import a
table-schema
without any associated data (via #852). This is very helpful. One of the key motivations of that issue was to allow a user to validate their data against a publishedtable-schema
before passing it on. However, while the package generated bydata-curator
does provide thetable-schema
used by the data provider, it is changed somewhat from what was originally imported via import column properties. Furthermore, any metadata in the table-schema is removed.This is a problem for us as we expect our format to evolve over time and thus we need to know which version of the
table-schema
was used in order to calibrate our ingestion routines.Desired Behavior
The most obvious solution would be to support the metadata described by the frictionless folks. I don't see any need to allow users to edit it within the tool, it is enough that it is preserved from import to export.
The second approach, which would also be acceptable, would be to hash (preferably via SHA1) the incoming table-schema (from import column properties), and emit this as a key under the table-schema section of the data-package. This would at least allow us to correlate the version that the user imported to our repository of table-schemas.
The text was updated successfully, but these errors were encountered: