Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to import metadata (data package schema or table schema) without data #987

Closed
pripley123 opened this issue Feb 11, 2020 · 9 comments
Labels
est:Moderate Moderate effort to implement est:Score=4 Score for estimate of effort required (scale of 1 upwards) f:Feature-request This issue is a request for a new feature support:Approved Approved to be done under the support agreement support This issue is a candidate to complete under the support agreement

Comments

@pripley123
Copy link

As a data provider and / or a reviewer of metadata
I want the ability to import metadata (data package schema or table schema) without data
so that I can review and (if necessary) modify the metadata without having to have the data (which may have personal information in it)

@ghost ghost added est:Moderate Moderate effort to implement est:Score=4 Score for estimate of effort required (scale of 1 upwards) f:Feature-request This issue is a request for a new feature labels Apr 22, 2020
@ghost
Copy link

ghost commented Apr 22, 2020

Hi @pripley123
I'll raise with the sponsors.
See #986 - It's certainly doable - but not sure what we'll have left for time yet after bug-fixes and sponsor priorities.

@ghost
Copy link

ghost commented Apr 23, 2020

Hi @pripley123
Sorry i had forgotten about our work in: #852
It may be that there's less to do here than I first thought. Were you already aware of this work?
image
Obviously there is your other issue to fix: #972 , but please let me know if this previous work is a step in the right direction

@ghost ghost added the support This issue is a candidate to complete under the support agreement label Apr 23, 2020
@ghost
Copy link

ghost commented May 18, 2020

Hi @pripley123
Short-listing this for release.
Let me know if this is still required, but I'm thinking that what I'd look at here is what else could be imported (say at table or package level) besides column properties.

@ghost ghost added this to the Import and Export enhancements milestone May 18, 2020
@markwheels markwheels added the support:Approved Approved to be done under the support agreement label May 18, 2020
@pripley123
Copy link
Author

pripley123 commented May 19, 2020

Hi @mattRedBox, thanks for raising with the sponsor and for info the re: importing table schema. Idea behind this one is a data provider might want to share only the metadata of their data and not the data itself - likely it'd be in the form a data package descriptor. That data package descriptor would include all the data package and table level attributes (as well as the column attributes). So if you imagine you received that data package descriptor from a data provider, you'd want to view it (and in some cases suggest changes to the metadata and send it back) so being able to view that metadata in Data Curator would be nice... (https://create.frictionlessdata.io/ allows uploading of data package descriptors but it only shows basic column information). To be transparent my project is developing a web based tool that will allow for the viewing of data package metadata so probably wouldn't have need of Data Curator for our particular situation, but I think it's still a worthwhile feature.

@ghost
Copy link

ghost commented May 22, 2020

Hi @pripley123
When opening a data package, without the data, I'm presuming you're OK with the Data Curator opening up a matching number of tabs even if they don't have data? It's difficult for DC to have table descriptors without a matching tab.
I'm not sure what to do yet about data that might already exist - at some point I think we're going to have to look at some sort of Preferences Option to either:

  • use existing data
  • open in fresh tabs (which is what it does at the moment).
    Also the other option to effectively 'reset' Data Curator back to 0 for a data package import (if there is existing data in Data Curator). This would also have to have the same options shown on closing as to prompting the user to save. I'll open these as separate issues.

@ghost
Copy link

ghost commented May 22, 2020

So to follow-up, @pripley123

  • looking at the existing behaviour of [Import Column Properties](Import Column Properties #206, Support view / edit of data package metadata #852 ), DC properties would use existing tables I think.
  • atm, when Importing Column Properties, the user gets a validation message that the incoming schema doesn't match and won't allow the import, I think if I get the time, I might be able to improve this for both by getting DC to show warning message with OK/cancel prompt. That way it can autofill the missing columns or tables, but a user if free to cancel if there's a particular order that tables or columns need to placed into first.

@ghost
Copy link

ghost commented May 22, 2020

I'll start with Import Package Properties without data as this is the simplest - it will behave the same as Open data package, so cascading to open Table properties and Column properties, but with no data.

@pripley123
Copy link
Author

@mattRedBox re: I'm presuming you're OK with the Data Curator opening up a matching number of tabs even if they don't have data?
Makes sense to me

@ghost
Copy link

ghost commented Jul 6, 2020

HI @pripley123
We're releasing an Import Data Package from URL with 1.2.0-beta. Importing from file or importing Table Properties didn't make it into this release due to time spent on #1003 and #988. I'll close this ticket and open up 2 new tickets for this work (Import Table Properties and Import Data Package from file).

ghost pushed a commit that referenced this issue Jul 6, 2020
@ghost ghost closed this as completed Jul 6, 2020
ghost pushed a commit that referenced this issue Apr 21, 2021
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
est:Moderate Moderate effort to implement est:Score=4 Score for estimate of effort required (scale of 1 upwards) f:Feature-request This issue is a request for a new feature support:Approved Approved to be done under the support agreement support This issue is a candidate to complete under the support agreement
Projects
None yet
Development

No branches or pull requests

2 participants