Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Import Column Properties #206

Closed
Stephen-Gates opened this issue Nov 8, 2017 · 4 comments
Closed

Import Column Properties #206

Stephen-Gates opened this issue Nov 8, 2017 · 4 comments
Labels
est:Moderate Moderate effort to implement est:Score=4 Score for estimate of effort required (scale of 1 upwards) f:Feature-request This issue is a request for a new feature fn:Set-Properties support:Approved Approved to be done under the support agreement support This issue is a candidate to complete under the support agreement
Milestone
Support release

Comments

@Stephen-Gates
Copy link
Contributor

Stephen-Gates commented Nov 8, 2017 •
edited
Loading

Desired Behaviour (for feature requests only)

As described at https://relishapp.com/odi-australia/data-curator/docs/backlog/import-column-properties
@Stephen-Gates Stephen-Gates added the f:Feature-request This issue is a request for a new feature label Nov 8, 2017
@Stephen-Gates Stephen-Gates added this to the Backlog milestone Nov 8, 2017
@Stephen-Gates Stephen-Gates modified the milestones: Backlog, v1.x.x Dec 1, 2017
@Stephen-Gates
Copy link
Contributor Author

Stephen-Gates commented Dec 13, 2017 •
edited by unfurl-links bot
Loading

A possible approach to providing a library of schema snippets https://github.com/Stephen-Gates/table-schema-snippets

GitHub
table-schema-snippets - A collection of field descriptions and constraints to help build a Frictionless Data table schema quickly

@Stephen-Gates Stephen-Gates modified the milestones: v1.x.x, Backlog Mar 24, 2018
@Stephen-Gates
Copy link
Contributor Author

May not be needed if implement #852

@ghost
Copy link

ghost commented Jun 19, 2019

Hi @markwheels
Split out from #852, to do the work required for Column Properties import, as I want to make sure that I've understood correctly.

My question is what happens when the number of columns in the CSV and Table Schema are not equal? We may need some extra validation because at the moment these can't be different.
I presume you're talking about the column properties imported?

Thinking yes that's the simplest way to go (unless I've misunderstood this?)

  • make it strict by ensuring current table and import both match

@ghost ghost added the est:Moderate Moderate effort to implement label Jun 19, 2019
@ghost ghost modified the milestones: Backlog, Support release Jun 19, 2019
@ghost ghost added support This issue is a candidate to complete under the support agreement est:Score=4 Score for estimate of effort required (scale of 1 upwards) labels Jun 19, 2019
@markwheels markwheels added the support:Approved Approved to be done under the support agreement label Jun 19, 2019
@markwheels
Copy link

Thank @mattRedBox and @Stephen-Gates , I have added the 'support:Approved' label.

ghost pushed a commit that referenced this issue Jun 28, 2019
#206: Basic structure for menu and lock toggle.
c7e09bc
ghost pushed a commit that referenced this issue Jun 28, 2019
#206: Closes #852. Added open schema as url (TODO: as file).
411fcbb
@ghost ghost closed this as completed in 18ea670 Jun 30, 2019
ghost pushed a commit that referenced this issue Jun 30, 2019
Closes #206: Ensure locked, not toggled for import. Add Tab behaviour…
20b15fe 
… to lock. Separated logic from main's url to frictionless for easier re-use. Added submenu items for both file and url. Improved style to suit open. Allowed title to change. Closes #742. Closes #731. Added Import Column Properties to file disable/enable list. Closes #924: Enabled difference between case-insensitive (with diacritics) and case-sensitive (without diacritics).

Signed-off-by: Matthew Mulholland <matt@redboxresearchdata.com.au>
ghost pushed a commit that referenced this issue Jun 30, 2019
Closes #206: Ensure locked, not toggled for import. Add Tab behaviour…
c1fcce4 
… to lock. Separated logic from main's url to frictionless for easier re-use. Added submenu items for both file and url. Improved style to suit open. Allowed title to change. Closes #742. Closes #731. Added Import Column Properties to file disable/enable list. Closes #924: Enabled difference between case-insensitive (with diacritics) and case-sensitive (without diacritics).
ghost pushed a commit that referenced this issue Jul 1, 2019
#206: Ensure locked, not toggled for import.
2195713
ghost pushed a commit that referenced this issue Jul 1, 2019
#206: Ensure locked, not toggled for import.
485924b
ghost pushed a commit that referenced this issue Jul 1, 2019
#206: Add Tab behaviour to lock.
e02f992
ghost pushed a commit that referenced this issue Jul 1, 2019
#206: tidy up function use.
2d1d276
ghost pushed a commit that referenced this issue Jul 1, 2019
#206: Separated logic from main's url to frictionless for easier re-u…
c4a150d 
…se. Added file open for resources schema and piped to new frictionless logic in place for url.
ghost pushed a commit that referenced this issue Jul 1, 2019
#206: Updated message (when page downloaded as say HTML vs JSON).
edc8a56
ghost pushed a commit that referenced this issue Jul 1, 2019
Closes #206: Added submenu items for both file and url. Improved styl…
a76c822 
…e to suit open. Allowed title to change. Closes #742. Closes #731.
ghost pushed a commit that referenced this issue Jul 1, 2019
Closes #206: Added Import Column Properties to file disable/enable list.
0ceebe7
@ghost ghost mentioned this issue Jul 2, 2019
Closed
@ghost ghost mentioned this issue May 22, 2020
Closed
ghost pushed a commit that referenced this issue Apr 21, 2021
#206: Basic structure for menu and lock toggle.
b704928
ghost pushed a commit that referenced this issue Apr 21, 2021
#206: Closes #852. Added open schema as url (TODO: as file).
fba593e
ghost pushed a commit that referenced this issue Apr 21, 2021
#206: Ensure locked, not toggled for import.
16dc906
ghost pushed a commit that referenced this issue Apr 21, 2021
#206: Ensure locked, not toggled for import.
fbdb232
ghost pushed a commit that referenced this issue Apr 21, 2021
#206: Add Tab behaviour to lock.
d3a5b49
ghost pushed a commit that referenced this issue Apr 21, 2021
#206: tidy up function use.
727d6d3
ghost pushed a commit that referenced this issue Apr 21, 2021
#206: Separated logic from main's url to frictionless for easier re-u…
09382ab 
…se. Added file open for resources schema and piped to new frictionless logic in place for url.
ghost pushed a commit that referenced this issue Apr 21, 2021
#206: Updated message (when page downloaded as say HTML vs JSON).
00a1964
ghost pushed a commit that referenced this issue Apr 21, 2021
Closes #206: Added submenu items for both file and url. Improved styl…
c0784c4 
…e to suit open. Allowed title to change. Closes #742. Closes #731.
ghost pushed a commit that referenced this issue Apr 21, 2021
Closes #206: Added Import Column Properties to file disable/enable list.
d7ba7fc
ghost pushed a commit that referenced this issue Apr 21, 2021
Closes #206: Ensure locked, not toggled for import. Add Tab behaviour…
22d1c26 
… to lock. Separated logic from main's url to frictionless for easier re-use. Added submenu items for both file and url. Improved style to suit open. Allowed title to change. Closes #742. Closes #731. Added Import Column Properties to file disable/enable list. Closes #924: Enabled difference between case-insensitive (with diacritics) and case-sensitive (without diacritics).
ghost pushed a commit that referenced this issue Apr 21, 2021
Closes #206: Ensure locked, not toggled for import. Add Tab behaviour…
1c5e9c4 
… to lock. Separated logic from main's url to frictionless for easier re-use. Added submenu items for both file and url. Improved style to suit open. Allowed title to change. Closes #742. Closes #731. Added Import Column Properties to file disable/enable list. Closes #924: Enabled difference between case-insensitive (with diacritics) and case-sensitive (without diacritics).

Signed-off-by: Matthew Mulholland <matt@redboxresearchdata.com.au>
ghost pushed a commit that referenced this issue Apr 21, 2021
Closes #206: Ensure locked, not toggled for import. Add Tab behaviour…
15f8e2c 
… to lock. Separated logic from main's url to frictionless for easier re-use. Added submenu items for both file and url. Improved style to suit open. Allowed title to change. Closes #742. Closes #731. Added Import Column Properties to file disable/enable list. Closes #924: Enabled difference between case-insensitive (with diacritics) and case-sensitive (without diacritics).
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
est:Moderate Moderate effort to implement est:Score=4 Score for estimate of effort required (scale of 1 upwards) f:Feature-request This issue is a request for a new feature fn:Set-Properties support:Approved Approved to be done under the support agreement support This issue is a candidate to complete under the support agreement
Projects
None yet
Milestone
Support release
Development

No branches or pull requests
2 participants
@Stephen-Gates @markwheels