Fix incorrect tag provided flag in tx pool #1786
Comments
kamilsa
added a commit
that referenced
this issue
Sep 5, 2023
This commit includes changes for dispute finality handling and experimentation on transaction pool implementation. The changes implemented in the core/dispute_coordinator/impl/dispute_coordinator_impl.cpp file remove all debugging statements to improve readability and ensure cleaner code. Some adjustments have also been made to improve efficiency and avoid unnecessary computations. In the file core/transaction_pool/impl/transaction_pool_impl.cpp, a commented assertion has been added, signifying a pending fix on issue #1786. Furthermore, configuration files for the zombienet had been deployed focusing on dispute resilience within the parachain validators' network layer. These configurations will prompt validation nodes to report any discrepancies on the chain, ensuring the integrity of the block records. These modifications are crucial for maintaining the stability, security, and efficiency of the blockchain system.
kamilsa
added a commit
that referenced
this issue
Sep 5, 2023
This commit includes changes for dispute finality handling and experimentation on transaction pool implementation. The changes implemented in the core/dispute_coordinator/impl/dispute_coordinator_impl.cpp file remove all debugging statements to improve readability and ensure cleaner code. Some adjustments have also been made to improve efficiency and avoid unnecessary computations. In the file core/transaction_pool/impl/transaction_pool_impl.cpp, a commented assertion has been added, signifying a pending fix on issue #1786. Furthermore, configuration files for the zombienet had been deployed focusing on dispute resilience within the parachain validators' network layer. These configurations will prompt validation nodes to report any discrepancies on the chain, ensuring the integrity of the block records. These modifications are crucial for maintaining the stability, security, and efficiency of the blockchain system.
kamilsa
added a commit
that referenced
this issue
Sep 5, 2023
* Comment assert, add zombienet test This commit includes changes for dispute finality handling and experimentation on transaction pool implementation. The changes implemented in the core/dispute_coordinator/impl/dispute_coordinator_impl.cpp file remove all debugging statements to improve readability and ensure cleaner code. Some adjustments have also been made to improve efficiency and avoid unnecessary computations. In the file core/transaction_pool/impl/transaction_pool_impl.cpp, a commented assertion has been added, signifying a pending fix on issue #1786. Furthermore, configuration files for the zombienet had been deployed focusing on dispute resilience within the parachain validators' network layer. These configurations will prompt validation nodes to report any discrepancies on the chain, ensuring the integrity of the block records. These modifications are crucial for maintaining the stability, security, and efficiency of the blockchain system. * Update and rename 0004-parachains-garbage-candidate.zndsl to 0007-parachains-garbage-candidate.zndsl Rename 1 * Rename 0004-parachains-garbage-candidate.toml to 0007-parachains-garbage-candidate.toml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Sometimes, during execution of zombienet-test-6 KAGOME crashes with with this assert being not satisfied.
The only place where tag_provided flag is set is here. It is not clear, how it could become false
The text was updated successfully, but these errors were encountered: