Comment tx pool assert, add dispute zombienet test #1788
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit includes changes for dispute finality handling and experimentation on transaction pool implementation. The changes implemented in the core/dispute_coordinator/impl/dispute_coordinator_impl.cpp file remove all debugging statements to improve readability and ensure cleaner code. Some adjustments have also been made to improve efficiency and avoid unnecessary computations. In the file core/transaction_pool/impl/transaction_pool_impl.cpp, a commented assertion has been added, signifying a pending fix on issue #1786. Furthermore, configuration files for the zombienet had been deployed focusing on dispute resilience within the parachain validators' network layer. These configurations will prompt validation nodes to report any discrepancies on the chain, ensuring the integrity of the block records. These modifications are crucial for maintaining the stability, security, and efficiency of the blockchain system.
igor-egorov
approved these changes
Sep 5, 2023
safinsaf
reviewed
Sep 5, 2023
turuslan
approved these changes
Sep 5, 2023
safinsaf
approved these changes
Sep 5, 2023
…achains-garbage-candidate.zndsl Rename 1
…age-candidate.toml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit includes changes for dispute finality handling and experimentation on transaction pool implementation. The changes implemented in the core/dispute_coordinator/impl/dispute_coordinator_impl.cpp file remove all debugging statements to improve readability and ensure cleaner code. Some adjustments have also been made to improve efficiency and avoid unnecessary computations.
In the file core/transaction_pool/impl/transaction_pool_impl.cpp, a commented assertion has been added, signifying a pending fix on issue #1786. Furthermore, configuration files for the zombienet had been deployed focusing on dispute resilience within the parachain validators' network layer. These configurations will prompt validation nodes to report any discrepancies on the chain, ensuring the integrity of the block records.
These modifications are crucial for maintaining the stability, security, and efficiency of the blockchain system.
Referenced issues
None
Description of the Change
We observed that sometimes assert is triggered in tx pool. It is not critical, so we temporarily commented it out and created an issue #1786
Also a new zombienet test was added, we need it to test scenario when disputes conclusion is false. It will be fixed in that issue #1787
Benefits
Foundation for future fixes
Possible Drawbacks
None