Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix babe start #1681

Merged
merged 5 commits into from
Jul 10, 2023
Merged

fix babe start #1681

merged 5 commits into from
Jul 10, 2023

Conversation

turuslan
Copy link
Contributor

@turuslan turuslan commented Jun 28, 2023 •
edited
Loading

Referenced issues

Description of the Change

  • don't start warp sync until block 1.
  • fix telemetry singleton causing rocksdb crash on exit.
  • fix state sync returned root Some(Zero) instead of None.
  • fix babe exiting after incomplete warp sync.

Benefits

  • babe doesn't crash on start after incomplete state sync after warp sync

Possible Drawbacks

@turuslan
fix babe start
1969de8 
Signed-off-by: turuslan <turuslan.devbox@gmail.com>
@turuslan
fix babe (warp needs restart, because block appender)
7da1b3f 
Signed-off-by: turuslan <turuslan.devbox@gmail.com>
@turuslan
Merge remote-tracking branch 'origin/master' into fix/babe-start
722ec2f 
Signed-off-by: turuslan <turuslan.devbox@gmail.com>
@turuslan turuslan merged commit 3e444bc into master Jul 10, 2023
@turuslan turuslan deleted the fix/babe-start branch July 10, 2023 11:33
@turuslan turuslan mentioned this pull request Jul 17, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Harrm Harrm Harrm approved these changes

@kamilsa kamilsa kamilsa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@turuslan @kamilsa @Harrm