Skip to content

Ignore deleted outputs in default workflows #3172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

antgonza
Copy link
Member

This is a simple change but adding tests for this is really hard in a test environment so decided to explain the reasons behind the change in the code so it can be used during this and future reviews.

@coveralls
Copy link

coveralls commented Feb 1, 2022

Coverage Status

coverage: 92.9% (+0.008%) from 92.892%
when pulling 7d41a34 on antgonza:ignore-deleted-outputs-in-default-workflows
into 7aa8a18 on qiita-spots:dev.

Copy link
Contributor

@charles-cowart charles-cowart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I also believe this might be difficult to simulate inside a unit-test.

@charles-cowart charles-cowart merged commit 881d4bd into qiita-spots:dev Feb 16, 2022
@antgonza antgonza mentioned this pull request Mar 15, 2022
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants