2022.2 #68
Merged
2022.2 #68
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charles-cowart
suggested changes
Jun 3, 2022
qp_qiime2/__init__.py
Outdated
| # As of qiime2-2022.2 nothing is filtered here, so let's raise | ||
| # an error so we can catch and review if this happens in the | ||
| # future | ||
| raise ValueError(f"[REVIEW] {pname} {mid} due to {ename}") | ||
| add_method = False |
There was a problem hiding this comment.
if you raise ValueError here, add_method will never be set to False. Is this desired?
There was a problem hiding this comment.
yes, if this happens we want everything to stop and have someone look - cause it should never happen.
There was a problem hiding this comment.
duh! Now, now I understand what you mean ... yes.
|
Right, but you have a statement that can never be reached afterwards. Would you mind removing it, please? Thank you!
… On Jun 3, 2022, at 11:12 AM, Antonio Gonzalez ***@***.***> wrote:
@antgonza commented on this pull request.
In qp_qiime2/__init__.py:
> @@ -155,6 +172,10 @@
# this is an odd one, first encountered:
# feature-classifier fit-classifier-naive-bayes
if ename == element.NOVALUE:
+ # As of qiime2-2022.2 nothing is filtered here, so let's raise
+ # an error so we can catch and review if this happens in the
+ # future
+ raise ValueError(f"[REVIEW] {pname} {mid} due to {ename}")
add_method = False
yes, if this happens we want everything to stop and have someone look - cause it should never happen.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because your review was requested.
|
charles-cowart
approved these changes
Jun 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating to 2022.2